Fix timeout issue during plugin activation (v1.2.2)

CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.2.2] - 2023-10-05
+### Fixed
+- Timeout issue during plugin activation
+- Potential infinite recursion in admin notices handling
+
+### Improved
+- Hook management to prevent performance issues
+- Optimized by only loading on plugins page
+
+## [1.2.1] - 2025-04-07
+### Improved
+- Fixed typos in documentation
+- Improved text clarity
+- Added question mark to first sentence for better readability
+
 ## [1.2] - 2025-04-07
 ### Added
 - Improved documentation with detailed explanation

README.md

@@ -1,30 +1,27 @@
 # Plugin Reference Cleaner
-
-Have you ever deleted a plugin some other way than on the `/wp-admin/plugins.php` page, you'll probabaly have been stuck with this annoying notifications that can't be cleared:
-
-> "The plugin folder-name/file-name.php has been deactivated due to an error: Plugin file does not exist."
-
-This small WordPress utility plugin adds a "Remove Reference" button to these plugin deactivation error notices, allowing you to clean up the invalid plugin entries in the database.
+Author: Marcus Quinn
+Author URI: https://www.wpallstars.com
+Version: 1.2.2
+License: GPL-2.0+
 
 ## Description
 
-When WordPress detects a plugin file that no longer exists but is still referenced in the database as active, it displays an error notice. This plugin enhances those notices with a button that allows you to safely remove the invalid reference with a single click.
+Have you ever deleted a plugin some other way than through the /wp-admin/plugins.php page? If so, you've probably been stuck with this annoying notification that can't be cleared:
 
-You can find these with `SELECT * FROM wp_options WHERE option_name = 'active_plugins';` — but, the cleanup involved removing the rogue entry, and renumbering the others. This plugin can simply do that for you at the click of a button added to that WP standard notification.
-
-It's probabaly something that should be added to WP core. If anyone from the core team wants to adopt this solution, it's GPL, so feel free.
-
-**Note:** This plugin only needs to be installed and active if you have an error notification showing like this:
 "The plugin folder-name/file-name.php has been deactivated due to an error: Plugin file does not exist."
 
-If you don't have this notification perpetually showing on your `/wp-admin/plugins.php` page, then you don't need this, but you might like to save or bookmark it for if ever you do.
+This small WordPress utility plugin adds a "Remove Reference" button to these plugin deactivation error notices, allowing you to clean up the invalid plugin entries in the database.
 
-**Testing:** Just delete any plugin (that you can replace) from your `/wp-content/plugins` directory, via ftp or however you manage your WordPress files, then revisit your `/wp-admin/plugins.php` page with this plugin active to show the "Remove Reference" button.
+When WordPress detects a plugin file that no longer exists but is still referenced in the database as active, it displays an error notice. This plugin enhances those notices with a button that allows you to safely remove the invalid reference with a single click.
 
-The only ways I know to clear this missing plugin notification are:
-1. Reinstall it and delete on the `/wp-admin/plugins.php` page.
-2. Run `SELECT * FROM wp_options WHERE option_name = 'active_plugins';` (or `wp_1_options`, `wp_2_options`, `wp_3_options`, etc on a multisite network, using the side id of the site affected) via phpMyAdmin or Adminer, etc, or via mysql via your server commandline. Then edit the record, copying the json into an AI LLM and asking it to update without the reference to the missing plugin.
-3. Use this plugin.
+You can find these with `SELECT * FROM wp_options WHERE option_name = 'active_plugins';` — but the cleanup involves removing the rogue entry, and renumbering all others. This plugin can simply do that for you at the click of a button added to that WP standard notification.
+
+It's probably something that should be added to WP core. If anyone from the core team wants to adopt this solution, it's GPL, so feel free.
+
+Note: This plugin only needs to be installed and active if you have an error notification showing at /wp-admin/plugins.php, like this:
+"The plugin folder-name/file-name.php has been deactivated due to an error: Plugin file does not exist."
+
+If you don't have this notification perpetually showing on your /wp-admin/plugins.php page, then you don't need this, but you might like to save or bookmark it for if ever you do.
 
 ## Features
 
@@ -48,10 +45,31 @@ The only ways I know to clear this missing plugin notification are:
 3. Click the button and confirm to remove the invalid plugin reference
 4. The page will refresh with the error notice removed
 
+## Changelog
+
+### 1.2.2
+* Fixed timeout issue during plugin activation
+* Improved hook management to prevent potential infinite recursion
+* Optimized performance by only loading on plugins page
+
+### 1.2.1
+* Fixed typos in documentation
+* Improved text clarity
+* Added question mark to first sentence for better readability
+
+### 1.2
+* Improved documentation with detailed explanation
+* Added SQL reference for technical users
+* Suggested potential inclusion in WordPress core
+
+### 1.1
+* Improved error handling
+* Added support for multisite installations
+* Enhanced security with proper capability checks
+
+### 1.0
+* Initial release
+
 ## Support
 
-For support, please visit [WP ALLSTARS](https://wpallstars.com)
-
-## License
-
-This plugin is licensed under the [GPL v2 or later](https://www.gnu.org/licenses/gpl-2.0.html). 
+For support, please visit https://wpallstars.com 

plugin-reference-cleaner.php

@@ -2,9 +2,9 @@
 /*
  * Plugin Name: Plugin Reference Cleaner
  * Description: Adds a "Remove Reference" button to plugin deactivation error notices, allowing users to clean up invalid plugin entries.
- * Version: 1.2
+ * Version: 1.2.2
  * Author: Marcus Quinn
- * Author URI: https://wpallstars.com
+ * Author URI: https://www.wpallstars.com
  * License: GPL-2.0+
  */
 
@@ -15,22 +15,21 @@ if (!defined('ABSPATH')) {
 
 class Plugin_Reference_Cleaner {
     public function __construct() {
-        // Hook into admin notices to modify plugin error messages
-        add_action('admin_notices', array($this, 'inject_remove_button'), 100);
-        add_action('network_admin_notices', array($this, 'inject_remove_button'), 100); // Ensure notices in network admin
+        // Only hook into admin actions when on the plugins page
+        add_action('current_screen', function($screen) {
+            if (isset($screen->id) && ($screen->id === 'plugins' || $screen->id === 'plugins-network')) {
+                // Hook into admin notices to modify plugin error messages
+                add_action('admin_notices', array($this, 'inject_remove_button'), 100);
+                add_action('network_admin_notices', array($this, 'inject_remove_button'), 100);
+            }
+        });
+        
         // Handle the AJAX request to remove the plugin reference
         add_action('wp_ajax_remove_plugin_reference', array($this, 'remove_plugin_reference'));
     }
 
     // Inject "Remove Reference" button only if a relevant notice exists
     public function inject_remove_button() {
-        global $pagenow;
-
-        // Only run on plugins.php or network admin plugins page
-        if (!in_array($pagenow, array('plugins.php', 'plugins.php'))) {
-            return;
-        }
-
         // Check if a "Plugin file does not exist" notice exists
         $notices = $this->get_admin_notices();
         $has_error_notice = false;
@@ -47,7 +46,7 @@ class Plugin_Reference_Cleaner {
                 }
             }
         }
-
+        
         // Only proceed if a relevant notice was found
         if (!$has_error_notice || empty($plugin_files)) {
             return;
@@ -117,11 +116,23 @@ class Plugin_Reference_Cleaner {
 
     // Helper function to capture admin notices
     private function get_admin_notices() {
+        // Static flag to prevent infinite recursion
+        static $is_capturing = false;
+        
+        // If already capturing, return empty to break potential loops
+        if ($is_capturing) {
+            return array();
+        }
+        
+        $is_capturing = true;
+        
         ob_start();
         do_action('admin_notices');
         do_action('network_admin_notices');
         $output = ob_get_clean();
         
+        $is_capturing = false;
+        
         if (empty($output)) {
             return array();
         }

readme.txt

@@ -1,12 +1,12 @@
 === Plugin Reference Cleaner ===
 Author: Marcus Quinn
-Author URI: https://wpallstars.com
-Version: 1.2
+Author URI: https://www.wpallstars.com
+Version: 1.2.2
 License: GPL-2.0+
 
 == Description ==
 
-Have you ever deleted a plugin some other way than on the /wp-admin/plugins.php page, you'll probably have been stuck with this annoying notification that can't be cleared:
+Have you ever deleted a plugin some other way than through the /wp-admin/plugins.php page? If so, you've probably been stuck with this annoying notification that can't be cleared:
 
 "The plugin folder-name/file-name.php has been deactivated due to an error: Plugin file does not exist."
 
@@ -14,7 +14,7 @@ This small WordPress utility plugin adds a "Remove Reference" button to these pl
 
 When WordPress detects a plugin file that no longer exists but is still referenced in the database as active, it displays an error notice. This plugin enhances those notices with a button that allows you to safely remove the invalid reference with a single click.
 
-You can find these with `SELECT * FROM wp_options WHERE option_name = 'active_plugins';` — but, the cleanup involved removing the rogue entry, and renumbering the others. This plugin can simply do that for you at the click of a button added to that WP standard notification.
+You can find these with `SELECT * FROM wp_options WHERE option_name = 'active_plugins';` — but the cleanup involves removing the rogue entry, and renumbering all others. This plugin can simply do that for you at the click of a button added to that WP standard notification.
 
 It's probably something that should be added to WP core. If anyone from the core team wants to adopt this solution, it's GPL, so feel free.
 
@@ -47,6 +47,16 @@ If you don't have this notification perpetually showing on your /wp-admin/plugin
 
 == Changelog ==
 
+= 1.2.2 =
+* Fixed timeout issue during plugin activation
+* Improved hook management to prevent potential infinite recursion
+* Optimized performance by only loading on plugins page
+
+= 1.2.1 =
+* Fixed typos in documentation
+* Improved text clarity
+* Added question mark to first sentence for better readability
+
 = 1.2 =
 * Improved documentation with detailed explanation
 * Added SQL reference for technical users