From 7bac0dc63dee2b88fe179081eec6168a7de45e64 Mon Sep 17 00:00:00 2001
From: Marcus Quinn <6428977+marcusquinn@users.noreply.github.com>
Date: Wed, 18 Mar 2026 21:38:00 +0000
Subject: [PATCH] t096: fix unconditional plugin activation assertion in
 cypress test (#101)

* fix: make plugin activation assertion unconditional in cypress test

Addresses Gemini Code Assist review feedback on PR #84 (issue #96).
The 'Plugin is activated' test was using an if/else guard that caused
it to silently pass when the plugin row was missing. Replaced with a
direct unconditional cy.get() + cy.within() assertion so the test
fails clearly if the plugin is not found.

Optional plugin checks (Plugin Toggle, Kadence Blocks) retain their
conditional logic as those are genuinely optional in the test env.

Closes #96

* fix: reduce duplicated Cypress assertion for SonarCloud

* fix: lower Sonar new-code duplication in playground test
---
 cypress/e2e/playground-single-site.cy.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/cypress/e2e/playground-single-site.cy.js b/cypress/e2e/playground-single-site.cy.js
index 0af51b7..a7176ec 100644
--- a/cypress/e2e/playground-single-site.cy.js
+++ b/cypress/e2e/playground-single-site.cy.js
@@ -18,14 +18,10 @@ describe('WordPress Playground Single Site Tests', () => {
     cy.visit('/wp-admin/plugins.php', { timeout: 30000 });
 
     cy.get('body', { timeout: 15000 }).then(($body) => {
-      // Verify the starter template plugin exists and is activated.
-      if ($body.find('tr[data-slug="wp-plugin-starter-template-for-ai-coding"]').length) {
-        cy.get('tr[data-slug="wp-plugin-starter-template-for-ai-coding"]').within(() => {
-          cy.get('.deactivate a').should('exist');
-        });
-      } else {
-        cy.log('Starter template plugin not found by slug, skipping check');
-      }
+      expect(
+        $body.find('tr[data-slug="wp-plugin-starter-template-for-ai-coding"] .deactivate a').length,
+        'Starter template plugin should be present and active'
+      ).to.be.greaterThan(0);
 
       if ($body.text().includes('Plugin Toggle')) {
         cy.contains('tr', 'Plugin Toggle').should('exist');