From 79f78882a63a77ba8e16447f6e92dad25eb5b73c Mon Sep 17 00:00:00 2001 From: Marcus Quinn <6428977+marcusquinn@users.noreply.github.com> Date: Tue, 17 Mar 2026 20:29:00 +0000 Subject: [PATCH] fix: remove redundant existence check, use cy.within() for scoped selector (#84) Addresses Gemini review feedback on PR #50 line 23: the .should('exist') check was redundant since the if-condition already confirms element presence. Refactored to use cy.within() to scope the .deactivate a check, eliminating selector repetition and improving readability. Closes #79 --- cypress/e2e/playground-single-site.cy.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cypress/e2e/playground-single-site.cy.js b/cypress/e2e/playground-single-site.cy.js index 28a60c8..0af51b7 100644 --- a/cypress/e2e/playground-single-site.cy.js +++ b/cypress/e2e/playground-single-site.cy.js @@ -20,8 +20,9 @@ describe('WordPress Playground Single Site Tests', () => { cy.get('body', { timeout: 15000 }).then(($body) => { // Verify the starter template plugin exists and is activated. if ($body.find('tr[data-slug="wp-plugin-starter-template-for-ai-coding"]').length) { - cy.get('tr[data-slug="wp-plugin-starter-template-for-ai-coding"]').should('exist'); - cy.get('tr[data-slug="wp-plugin-starter-template-for-ai-coding"] .deactivate a').should('exist'); + cy.get('tr[data-slug="wp-plugin-starter-template-for-ai-coding"]').within(() => { + cy.get('.deactivate a').should('exist'); + }); } else { cy.log('Starter template plugin not found by slug, skipping check'); }