More yoda conditions

This commit is contained in:
David Stone
2025-02-09 12:30:02 -07:00
parent d9122a410d
commit 0a4c81c105
97 changed files with 323 additions and 289 deletions

View File

@ -71,6 +71,6 @@ class Limit_Customer_User_Role extends Limit {
$default_value = wu_get_setting('default_role', 'administrator');
return empty($this->limit) || $this->limit === 'default' ? $default_value : $this->limit;
return empty($this->limit) || 'default' === $this->limit ? $default_value : $this->limit;
}
}

View File

@ -45,13 +45,13 @@ class Limit_Plugins extends Limit {
$plugin = (object) $this->{$value_to_check};
$types = [
'visible' => $plugin->visibility === 'visible',
'hidden' => $plugin->visibility === 'hidden',
'default' => $plugin->behavior === 'default',
'force_active' => $plugin->behavior === 'force_active',
'force_inactive' => $plugin->behavior === 'force_inactive',
'force_active_locked' => $plugin->behavior === 'force_active_locked',
'force_inactive_locked' => $plugin->behavior === 'force_inactive_locked',
'visible' => 'visible' === $plugin->visibility,
'hidden' => 'hidden' === $plugin->visibility,
'default' => 'default' === $plugin->behavior,
'force_active' => 'force_active' === $plugin->behavior,
'force_inactive' => 'force_inactive' === $plugin->behavior,
'force_active_locked' => 'force_active_locked' === $plugin->behavior,
'force_inactive_locked' => 'force_inactive_locked' === $plugin->behavior,
];
return wu_get_isset($types, $type, false);

View File

@ -87,9 +87,9 @@ class Limit_Site_Templates extends Limit {
$template = (object) $this->{$value_to_check};
$types = [
'available' => $template->behavior === 'available',
'not_available' => $template->behavior === 'not_available',
'pre_selected' => $template->behavior === 'pre_selected',
'available' => 'available' === $template->behavior,
'not_available' => 'not_available' === $template->behavior,
'pre_selected' => 'pre_selected' === $template->behavior,
];
return wu_get_isset($types, $type, true);
@ -178,7 +178,7 @@ class Limit_Site_Templates extends Limit {
foreach ($limits as $site_id => $site_settings) {
$site_settings = (object) $site_settings;
if ($site_settings->behavior === 'available' || $site_settings->behavior === 'pre_selected' || $this->mode === 'default') {
if ('available' === $site_settings->behavior || 'pre_selected' === $site_settings->behavior || 'default' === $this->mode) {
$available[] = $site_id;
}
}
@ -205,7 +205,7 @@ class Limit_Site_Templates extends Limit {
foreach ($limits as $site_id => $site_settings) {
$site_settings = (object) $site_settings;
if ($site_settings->behavior === 'pre_selected') {
if ('pre_selected' === $site_settings->behavior) {
$pre_selected_site_template = $site_id;
}
}

View File

@ -53,10 +53,10 @@ class Limit_Themes extends Limit {
$theme = (object) $this->{$value_to_check};
$types = [
'visible' => $theme->visibility === 'visible',
'hidden' => $theme->visibility === 'hidden',
'available' => $theme->behavior === 'available',
'not_available' => $theme->behavior === 'not_available',
'visible' => 'visible' === $theme->visibility,
'hidden' => 'hidden' === $theme->visibility,
'available' => 'available' === $theme->behavior,
'not_available' => 'not_available' === $theme->behavior,
];
return wu_get_isset($types, $type, false);
@ -136,7 +136,7 @@ class Limit_Themes extends Limit {
foreach ($limits as $theme_slug => $theme_settings) {
$theme_settings = (object) $theme_settings;
if ($theme_settings->behavior === 'available') {
if ('available' === $theme_settings->behavior) {
$available[] = $theme_slug;
}
}
@ -160,14 +160,14 @@ class Limit_Themes extends Limit {
return $active_theme;
}
if ($this->forced_active_theme !== null) {
if (null !== $this->forced_active_theme) {
return $this->forced_active_theme;
}
foreach ($limits as $theme_slug => $theme_settings) {
$theme_settings = (object) $theme_settings;
if ($theme_settings->behavior === 'force_active') {
if ('force_active' === $theme_settings->behavior) {
$active_theme = $theme_slug;
}
}