Code cleanup and Git Updater integration improvements (v1.6.13)

git checkout main
Merge tag 'v1.6.4'

Release version 1.6.4

.ai-assistant.md

@@ -79,23 +79,30 @@ Before creating a new release, verify the following:
    - `FPDEN_VERSION` constant in the main plugin file
    - `readme.txt` (Stable tag)
    - `README.md` (Ensure changelog is updated)
+   - `languages/fix-plugin-does-not-exist-notices.pot` (Project-Id-Version)
    - Any other files that reference the version number
 3. Update CHANGELOG.md with all changes
 4. Update readme.txt changelog section
 5. Update README.md changelog section to match readme.txt
 6. Commit changes: `git commit -m "Prepare release v{MAJOR}.{MINOR}.{PATCH}"`
-7. Push branch to all remotes:
+7. Test changes locally on the version branch
+8. When satisfied with testing, merge to main:
    ```
-   git push github HEAD:v{MAJOR}.{MINOR}.{PATCH}
-   git push gitea HEAD:v{MAJOR}.{MINOR}.{PATCH}
+   git checkout main
+   git merge v{MAJOR}.{MINOR}.{PATCH} --no-ff
    ```
-8. Create and push a tag to trigger the GitHub Actions workflow:
+9. Push main to all remotes:
+   ```
+   git push github main
+   git push gitea main
+   ```
+10. Create and push a tag to trigger the GitHub Actions workflow:
     ```
     git tag -a v{MAJOR}.{MINOR}.{PATCH} -m "Release version {MAJOR}.{MINOR}.{PATCH}"
     git push github refs/tags/v{MAJOR}.{MINOR}.{PATCH}
     git push gitea refs/tags/v{MAJOR}.{MINOR}.{PATCH}
     ```
-9. Verify the GitHub Actions workflow completes successfully
+11. Verify the GitHub Actions workflow completes successfully
 
 ## Build Process
 
@@ -141,6 +148,7 @@ Before releasing:
 
 ```
 # 1. Create a new branch
+git checkout main
 git checkout -b v1.7.0
 
 # 2. Update version numbers in ALL required files
@@ -148,17 +156,25 @@ git checkout -b v1.7.0
 # - CHANGELOG.md
 # - readme.txt
 # - README.md
+# - languages/fix-plugin-does-not-exist-notices.pot
 # - FPDEN_VERSION constant
 
 # 3. Commit changes
 git add .
 git commit -m "Prepare release v1.7.0"
 
-# 4. Push to remotes
-git push github HEAD:v1.7.0
-git push gitea HEAD:v1.7.0
+# 4. Test changes locally on the version branch
+# (Run tests, verify functionality)
 
-# 5. Create and push tag
+# 5. Merge to main when ready
+git checkout main
+git merge v1.7.0 --no-ff
+
+# 6. Push main to remotes
+git push github main
+git push gitea main
+
+# 7. Create and push tag
 git tag -a v1.7.0 -m "Release version 1.7.0"
 git push github refs/tags/v1.7.0
 git push gitea refs/tags/v1.7.0
@@ -167,29 +183,53 @@ git push gitea refs/tags/v1.7.0
 ### Adding a New Feature
 
 ```
-# 1. Create feature branch
+# 1. Create feature branch from main
+git checkout main
 git checkout -b feature/new-feature-name
 
 # 2. Make changes and commit
 git add .
 git commit -m "Add new feature"
 
-# 3. Push to remotes
-git push github HEAD:feature/new-feature-name
-git push gitea HEAD:feature/new-feature-name
+# 3. Test locally
+# (Run tests, verify functionality)
+
+# 4. When ready for release, merge to a version branch
+git checkout -b v1.7.0
+git merge feature/new-feature-name --no-ff
+
+# 5. Continue with the release process
+# (Update version numbers, etc.)
 ```
 
 ### Fixing a Bug
 
 ```
-# 1. Create bugfix branch
+# 1. Create bugfix branch from main
+git checkout main
 git checkout -b fix/bug-description
 
 # 2. Make changes and commit
 git add .
 git commit -m "Fix #123: Fix bug description"
 
-# 3. Push to remotes
-git push github HEAD:fix/bug-description
-git push gitea HEAD:fix/bug-description
+# 3. Test locally
+# (Run tests, verify functionality)
+
+# 4. When ready for release, merge to a version branch
+git checkout -b v1.6.5
+git merge fix/bug-description --no-ff
+
+# 5. Continue with the release process
+# (Update version numbers, etc.)
+```
+
+### Testing a Previous Version
+
+```
+# Checkout a specific tag for testing
+git checkout v1.6.3
+
+# Or create a test branch from a specific tag
+git checkout v1.6.3 -b test/some-feature
 ```

.github/ai-workflows/bug-fixing.md

@@ -64,27 +64,60 @@ git commit -m "Fix #123: Brief description of the bug fix"
 
 If there's an issue number, reference it in the commit message.
 
-### 7. Push to Remote
+### 7. Prepare for Release
 
-Push the bug fix branch to the remote repositories:
+When the bug fix is ready to be released:
+
+1. Create a version branch for the release:
+
+```bash
+git checkout -b v{MAJOR}.{MINOR}.{PATCH}
+```
+
+2. Merge your bug fix branch into the version branch:
+
+```bash
+git merge fix/bug-description --no-ff
+```
+
+3. Update version numbers and changelog entries
+
+4. Follow the standard release process from this point
+
+### 8. Push to Remote (Optional for Collaboration)
+
+If you need to collaborate with others on the bug fix before it's ready for release:
 
 ```bash
 git push github HEAD:fix/bug-description
 git push gitea HEAD:fix/bug-description
 ```
 
-### 8. Create Pull Request (Optional)
+### 9. Create Pull Request (Optional)
 
-If the repository uses pull requests for code review, create a pull request from the bug fix branch to the main branch.
+If the repository uses pull requests for code review, create a pull request from the bug fix branch to the version branch.
 
 ## Determining Version Increment
 
 After fixing a bug, determine the appropriate version increment:
 
 - **PATCH** (e.g., 1.6.0 → 1.6.1): For most bug fixes that don't change functionality
+  - **IMPORTANT**: Always increment the patch version for every change, even small ones, to make rollbacks easier if issues are found in testing
 - **MINOR** (e.g., 1.6.0 → 1.7.0): For bug fixes that introduce new features or significant changes
 - **MAJOR** (e.g., 1.6.0 → 2.0.0): For bug fixes that introduce breaking changes
 
+## Testing Previous Versions
+
+To test a previous version of the plugin:
+
+```bash
+# Checkout a specific tag for testing
+git checkout v{MAJOR}.{MINOR}.{PATCH}
+
+# Or create a test branch from a specific tag
+git checkout v{MAJOR}.{MINOR}.{PATCH} -b test/some-feature
+```
+
 ## Hotfix Process
 
 For critical bugs that need immediate fixing in a released version:
@@ -108,6 +141,8 @@ Increment the PATCH version and update all version numbers:
 - FPDEN_VERSION constant
 - CHANGELOG.md
 - readme.txt
+- README.md
+- languages/fix-plugin-does-not-exist-notices.pot (Project-Id-Version)
 
 ### 4. Commit and Push
 

.github/ai-workflows/feature-development.md

@@ -33,6 +33,7 @@ Update relevant documentation to reflect the new feature:
 - Add a description to CHANGELOG.md under an "Unreleased" section
 - Update readme.txt if the feature affects user-facing functionality
 - Update inline documentation/comments
+- Remember that any feature addition will require a version increment in all relevant files
 
 ### 4. Testing
 
@@ -52,18 +53,38 @@ git add .
 git commit -m "Add feature: descriptive name"
 ```
 
-### 6. Push to Remote
+### 6. Prepare for Release
 
-Push the feature branch to the remote repositories:
+When the feature is ready to be released:
+
+1. Create a version branch for the release:
+
+```bash
+git checkout -b v{MAJOR}.{MINOR}.{PATCH}
+```
+
+2. Merge your feature branch into the version branch:
+
+```bash
+git merge feature/descriptive-name --no-ff
+```
+
+3. Update version numbers and changelog entries
+
+4. Follow the standard release process from this point
+
+### 7. Push to Remote (Optional for Collaboration)
+
+If you need to collaborate with others on the feature before it's ready for release:
 
 ```bash
 git push github HEAD:feature/descriptive-name
 git push gitea HEAD:feature/descriptive-name
 ```
 
-### 7. Create Pull Request (Optional)
+### 8. Create Pull Request (Optional)
 
-If the repository uses pull requests for code review, create a pull request from the feature branch to the main branch.
+If the repository uses pull requests for code review, create a pull request from the feature branch to the version branch.
 
 ## Code Standards and Best Practices
 

.github/ai-workflows/release-process.md

@@ -15,6 +15,7 @@ This document provides step-by-step instructions for AI assistants to help with
 Based on the changes made, determine the appropriate version increment:
 
 1. **PATCH** (e.g., 1.6.0 → 1.6.1): For bug fixes and minor improvements
+   - **IMPORTANT**: Always increment the patch version for every change, even small ones, to make rollbacks easier if issues are found in testing
 2. **MINOR** (e.g., 1.6.0 → 1.7.0): For new features and significant improvements
 3. **MAJOR** (e.g., 1.6.0 → 2.0.0): For breaking changes
 
@@ -72,7 +73,16 @@ Add a new section at the top of the CHANGELOG.md file:
 - Bug fix 2
 ```
 
-#### c. readme.txt
+#### c. POT File (languages/fix-plugin-does-not-exist-notices.pot)
+
+Update the Project-Id-Version and POT-Creation-Date:
+
+```
+"Project-Id-Version: Fix 'Plugin file does not exist.' Notices {MAJOR}.{MINOR}.{PATCH}\n"
+"POT-Creation-Date: YYYY-MM-DDT00:00:00+00:00\n"
+```
+
+#### d. readme.txt
 
 Update the stable tag:
 
@@ -102,18 +112,38 @@ Brief description of the most important changes in this release
 ### 3. Commit Changes
 
 ```bash
-git add fix-plugin-does-not-exist-notices.php CHANGELOG.md readme.txt
+git add fix-plugin-does-not-exist-notices.php CHANGELOG.md readme.txt README.md languages/fix-plugin-does-not-exist-notices.pot
 git commit -m "Prepare release v{MAJOR}.{MINOR}.{PATCH}"
 ```
 
-### 4. Push Branch to Remotes
+### 4. Test Changes Locally
+
+Test the changes thoroughly on the version branch to ensure everything works as expected:
+
+- Test with the latest WordPress version
+- Test with PHP 7.0+ (minimum supported version)
+- Verify all features work as expected
+- Check for any PHP warnings or notices
+
+### 5. Merge to Main
+
+When satisfied with testing, merge the version branch to main:
 
 ```bash
-git push github HEAD:v{MAJOR}.{MINOR}.{PATCH}
-git push gitea HEAD:v{MAJOR}.{MINOR}.{PATCH}
+git checkout main
+git merge v{MAJOR}.{MINOR}.{PATCH} --no-ff
 ```
 
-### 5. Create and Push Tag
+The `--no-ff` flag creates a merge commit even if a fast-forward merge is possible, which helps preserve the branch history.
+
+### 6. Push Main to Remotes
+
+```bash
+git push github main
+git push gitea main
+```
+
+### 7. Create and Push Tag
 
 ```bash
 git tag -a v{MAJOR}.{MINOR}.{PATCH} -m "Release version {MAJOR}.{MINOR}.{PATCH}"
@@ -121,17 +151,29 @@ git push github refs/tags/v{MAJOR}.{MINOR}.{PATCH}
 git push gitea refs/tags/v{MAJOR}.{MINOR}.{PATCH}
 ```
 
-### 6. Monitor GitHub Actions
+### 8. Monitor GitHub Actions
 
 Open the GitHub Actions page to monitor the build and deployment process:
 https://github.com/wpallstars/fix-plugin-does-not-exist-notices/actions
 
-### 7. Verify Release
+### 9. Verify Release
 
 - [ ] Check that the GitHub release was created successfully
 - [ ] Verify that the plugin was deployed to WordPress.org
 - [ ] Test the plugin from WordPress.org to ensure it works correctly
 
+## Testing Previous Versions
+
+To test a previous version of the plugin:
+
+```bash
+# Checkout a specific tag for testing
+git checkout v{MAJOR}.{MINOR}.{PATCH}
+
+# Or create a test branch from a specific tag
+git checkout v{MAJOR}.{MINOR}.{PATCH} -b test/some-feature
+```
+
 ## Rollback Procedure (If Needed)
 
 If issues are discovered after release:
@@ -151,16 +193,27 @@ Make the necessary changes to fix the issues.
 
 Increment the PATCH version and update all version numbers as described above.
 
-### 4. Commit and Push
+### 4. Test the Hotfix
+
+Test the hotfix thoroughly to ensure it resolves the issue without introducing new problems.
+
+### 5. Commit Changes
 
 ```bash
 git add .
 git commit -m "Fix issues in v{MAJOR}.{MINOR}.{PATCH}"
-git push github HEAD:hotfix/v{MAJOR}.{MINOR}.{PATCH+1}
-git push gitea HEAD:hotfix/v{MAJOR}.{MINOR}.{PATCH+1}
 ```
 
-### 5. Create and Push Tag
+### 6. Merge to Main
+
+```bash
+git checkout main
+git merge hotfix/v{MAJOR}.{MINOR}.{PATCH+1} --no-ff
+git push github main
+git push gitea main
+```
+
+### 7. Create and Push Tag
 
 ```bash
 git tag -a v{MAJOR}.{MINOR}.{PATCH+1} -m "Hotfix release version {MAJOR}.{MINOR}.{PATCH+1}"
@@ -168,6 +221,6 @@ git push github refs/tags/v{MAJOR}.{MINOR}.{PATCH+1}
 git push gitea refs/tags/v{MAJOR}.{MINOR}.{PATCH+1}
 ```
 
-### 6. Monitor and Verify
+### 8. Monitor and Verify
 
-Follow steps 6 and 7 from the release process to monitor and verify the hotfix release.
+Follow steps 8 and 9 from the release process to monitor and verify the hotfix release.

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.6.4] - 2024-05-16
+### Improved
+- Version management to ensure consistent patch version increments
+- Documentation for version update process
+- AI workflow files with detailed version increment instructions
+
 ## [1.6.3] - 2024-05-15
 ### Fixed
 - Git Updater repository URLs to use full repository paths

README.md

@@ -120,6 +120,74 @@ The plugin works by:
 
 ## Changelog
 
+### 1.6.13
+* Code cleanup and optimization
+* Improved Git Updater integration
+* Fixed author display in plugin information
+* Ensured compatibility with WordPress 6.4
+
+### 1.6.12
+* Added WP ALLSTARS as a co-author
+* Updated author information and links
+* Added author websites to plugin description
+* Fixed issue with multiple author URLs
+
+### 1.6.11
+* CRITICAL FIX: Completely removed auto-deactivation prevention code that was causing fatal errors
+* Simplified plugin functionality to focus on core features only
+* Improved compatibility with various WordPress configurations
+* Ensured plugin works correctly when other plugins are deleted
+
+### 1.6.10
+* Fixed critical error that could occur when a plugin folder is deleted
+* Improved error handling with try/catch blocks
+* Added more specific checks for the plugins page
+* Enhanced compatibility with various WordPress configurations
+* Made the code more defensive to prevent potential issues
+
+### 1.6.9
+* Fixed issue with notices not appearing below WordPress error messages
+* Improved JavaScript detection of WordPress error notices
+* Prevented WordPress from automatically clearing error notices on page refresh
+* Added multiple timing attempts to ensure notices appear correctly
+* Enhanced error notice targeting for better compatibility
+
+### 1.6.8
+* Fixed notice positioning to appear directly below WordPress error messages
+* Improved notice width to match WordPress error messages
+* Updated explanatory text for better clarity
+* Fixed issue with notices not appearing in some cases
+* Improved JavaScript detection of WordPress error messages
+
+### 1.6.7
+* Fixed duplicate notices issue by removing PHP-generated notice
+* Simplified notice system to only show one notice below WordPress error
+* Ensured consistent terminology with "Remove Notice" text
+* Optimized plugin detection with caching to improve performance
+* Fixed JavaScript to correctly handle multiple error messages
+
+### 1.6.6
+* Fixed issue with "Remove Notice" link not appearing on missing plugin rows
+* Fixed issue with automatic removal of plugin references without user action
+* Fixed notice positioning to ensure it appears below error messages
+* Restored pointer triangle to indicate relationship with error message
+* Improved detection of missing plugins in the plugin list
+* Enhanced scroll functionality to work with all plugin types
+
+### 1.6.5
+* Fixed duplicate notices issue - now only one notice appears below error messages
+* Changed notice heading to "Fix Plugin Does Not Exist Notices ☝️"
+* Updated explanatory text to be more clear about the removal process
+* Changed "Remove Reference" link text to "Remove Notice" for better clarity
+* Made "(File Missing)" text bold and red for better visibility
+* Fixed scroll functionality to work with all plugin rows
+* Improved JavaScript to prevent multiple notices from appearing
+
+### 1.6.4
+* Updated version management to ensure consistent patch version increments
+* Improved documentation for version update process
+* Enhanced AI workflow files with detailed version increment instructions
+
 ### 1.6.3
 * Fixed Git Updater repository URLs to use full repository paths
 * Corrected Update URI configuration for proper update detection

assets/css/admin-styles.css

@@ -5,6 +5,9 @@
     margin: 5px 0 15px;
     font-size: 14px;
     position: relative;
+    width: 100%;
+    box-sizing: border-box;
+    max-width: none;
 }
 .prc-notice h3 {
     margin-top: 0;
@@ -23,6 +26,13 @@
 }
 
 /* Style for highlighting the missing plugin row */
-tr.inactive.prc-highlight-missing {
+tr.inactive.prc-highlight-missing,
+tr.active.prc-highlight-missing {
     background-color: #fff8e5 !important; /* Use !important to override default styles */
 }
+
+/* Make File Missing text bold and red */
+span.error {
+    font-weight: bold !important;
+    color: #dc3232 !important;
+}

assets/js/admin-scripts.js

@@ -1,16 +1,43 @@
 (function() {
+    // Track if we've already added our notice
+    var noticeAdded = false;
+
     // Function to inject our notice
     function injectNotice() {
+        // If we've already added a notice, don't add another one
+        if (noticeAdded) {
+            return;
+        }
+
         // Find all notification containers first
-        var noticeContainers = document.querySelectorAll('.notice, .error, .updated');
+        var noticeContainers = document.querySelectorAll('.notice, .error, .updated, div.error');
+        var targetNotice = null;
 
         // Find all error notifications about missing plugins
         noticeContainers.forEach(function(notice) {
-            if (notice.textContent.includes('Plugin file does not exist') ||
-                notice.textContent.includes('has been deactivated due to an error')) {
+            if ((notice.textContent.includes('Plugin file does not exist') ||
+                notice.textContent.includes('has been deactivated due to an error')) &&
+                (notice.classList.contains('error') || notice.classList.contains('notice-error'))) {
+                // We'll use the last matching notice as our target
+                targetNotice = notice;
+                console.log('Found WordPress error notice:', notice.textContent);
+            }
+        });
 
+        // If we didn't find a specific error notice, look for the general WordPress error at the top
+        if (!targetNotice) {
+            // Try to find the WordPress error message at the top of the page
+            var wpError = document.querySelector('.error:not(.below-h2), div.error:not(.below-h2), .notice-error:not(.below-h2)');
+            if (wpError) {
+                targetNotice = wpError;
+                console.log('Found general WordPress error notice');
+            }
+        }
+
+        // If we found a target notice, add our custom notice after it
+        if (targetNotice) {
             // Check if we already added our notice
-                if (notice.nextElementSibling && notice.nextElementSibling.classList.contains('prc-notice')) {
+            if (targetNotice.nextElementSibling && targetNotice.nextElementSibling.classList.contains('prc-notice')) {
                 return;
             }
 
@@ -20,47 +47,59 @@
 
             // Add content using localized strings passed via wp_localize_script
             var pluginMissingText = typeof fpdenData !== 'undefined' && fpdenData.i18n && fpdenData.i18n.pluginMissing ?
-                    fpdenData.i18n.pluginMissing : 'Plugin file missing';
-                var removeReferenceText = typeof fpdenData !== 'undefined' && fpdenData.i18n && fpdenData.i18n.removeReference ?
-                    fpdenData.i18n.removeReference : 'Remove Reference';
+                fpdenData.i18n.pluginMissing : 'File Missing';
+            var removeNoticeText = typeof fpdenData !== 'undefined' && fpdenData.i18n && fpdenData.i18n.removeNotice ?
+                fpdenData.i18n.removeNotice : 'Remove Notice';
             var clickToScrollText = typeof fpdenData !== 'undefined' && fpdenData.i18n && fpdenData.i18n.clickToScroll ?
-                    fpdenData.i18n.clickToScroll : 'Click here to scroll to missing plugins';
+                fpdenData.i18n.clickToScroll : 'Click here to scroll to and highlight missing plugins';
 
-                ourNotice.innerHTML = '<h3 style="margin-top:0;color:#826200;">👉 Fix Plugin Does Not Exist Notices Can Fix This</h3>' +
-                    '<p>To remove the above error notification, scroll down to find the plugin marked with "<strong style="color:red">(' + pluginMissingText + ')</strong>" and click its "<strong>' + removeReferenceText + '</strong>" link.</p>' +
-                    '<p>This will permanently remove the missing plugin reference from your database.</p>' +
+            ourNotice.innerHTML = '<h3 style="margin-top:0;color:#826200;">Fix Plugin Does Not Exist Notices 👆</h3>' +
+                '<p>To remove these notices, scroll down to each plugin\'s name.php row, followed by: "<strong style="color:red">(' + pluginMissingText + ')</strong>". Then, click the "<strong>' + removeNoticeText + '</strong>" link for that plugin.</p>' +
+                '<p>This safely removes the missing active plugin reference from your database.</p>' +
+                '<p>Calls the standard WordPress function to update your active plugin options table, leaving only the remaining plugins installed and active.</p>' +
                 '<p><a href="#" id="prc-scroll-to-plugin" style="font-weight:bold;text-decoration:underline;color:#826200;">' + clickToScrollText + '</a></p>';
 
             // Insert our notice right after the error
-                notice.parentNode.insertBefore(ourNotice, notice.nextSibling);
+            targetNotice.parentNode.insertBefore(ourNotice, targetNotice.nextSibling);
+
+            // Make sure our notice has the same width as the WordPress error notice
+            ourNotice.style.width = targetNotice.offsetWidth + 'px';
+            ourNotice.style.maxWidth = '100%';
+            ourNotice.style.boxSizing = 'border-box';
+
+            // Mark that we've added our notice
+            noticeAdded = true;
 
             // Add scroll behavior
             var scrollLink = document.getElementById('prc-scroll-to-plugin');
             if (scrollLink) {
                 scrollLink.addEventListener('click', function(e) {
                     e.preventDefault();
-                        var missingPlugins = document.querySelectorAll('tr.inactive:not(.plugin-update-tr)');
-                        for (var i = 0; i < missingPlugins.length; i++) {
-                            if (missingPlugins[i].textContent.includes('(File Missing)')) {
+                    // Look for all plugin rows, not just inactive ones
+                    var allPluginRows = document.querySelectorAll('tr.active, tr.inactive');
+                    for (var i = 0; i < allPluginRows.length; i++) {
+                        if (allPluginRows[i].textContent.includes('(File Missing)')) {
                             // Add a class for highlighting instead of direct style manipulation
-                                missingPlugins[i].classList.add('prc-highlight-missing');
-                                missingPlugins[i].scrollIntoView({ behavior: 'smooth', block: 'center' });
+                            allPluginRows[i].classList.add('prc-highlight-missing');
+                            allPluginRows[i].scrollIntoView({ behavior: 'smooth', block: 'center' });
                             // Optional: Remove highlight after a delay
+                            (function(row) {
                                 setTimeout(function() {
-                                    missingPlugins[i].classList.remove('prc-highlight-missing');
+                                    row.classList.remove('prc-highlight-missing');
                                 }, 3000); // Remove highlight after 3 seconds
+                            })(allPluginRows[i]);
                             return;
                         }
                     }
                 });
             }
         }
-        });
     }
 
     // Try to inject notices on multiple events to ensure it works
     document.addEventListener('DOMContentLoaded', function() {
-        injectNotice();
+        // Delay the initial injection to ensure WordPress has fully loaded its notices
+        setTimeout(injectNotice, 100);
 
         // Also set up a MutationObserver to watch for dynamically added notices
         var observer = new MutationObserver(function(mutations) {
@@ -68,8 +107,8 @@
                 if (mutation.addedNodes && mutation.addedNodes.length > 0) {
                     // Check if added nodes are notices or contain notices
                     mutation.addedNodes.forEach(function(node) {
-                        if (node.nodeType === 1 && (node.matches('.notice, .error, .updated') || node.querySelector('.notice, .error, .updated'))) {
-                            injectNotice();
+                        if (node.nodeType === 1 && (node.matches('.notice, .error, .updated, div.error') || node.querySelector('.notice, .error, .updated, div.error'))) {
+                            setTimeout(injectNotice, 50); // Small delay to ensure the DOM is updated
                         }
                     });
                 }
@@ -85,4 +124,9 @@
         setTimeout(injectNotice, 500); // Delay slightly to ensure dynamic content is loaded
     });
 
+    // Additional attempt after a longer delay to catch late-loading notices
+    window.addEventListener('load', function() {
+        setTimeout(injectNotice, 1000); // Longer delay as final attempt
+    });
+
 })();

fix-plugin-does-not-exist-notices.php

@@ -12,9 +12,9 @@
  * @wordpress-plugin
  * Plugin Name: Fix 'Plugin file does not exist.' Notices
  * Plugin URI: https://wordpress.org/plugins/fix-plugin-does-not-exist-notices/
- * Description: Adds missing plugins to the plugins list with a "Remove Reference" link so you can permanently clean up invalid plugin entries and remove error notices.
- * Version: 1.6.3
- * Author: Marcus Quinn
+ * Description: Adds missing plugins to the plugins list with a "Remove Reference" link so you can permanently clean up invalid plugin entries and remove error notices. By Marcus Quinn (marcusquinn.com) & WP ALLSTARS (wpallstars.com).
+ * Version: 1.6.13
+ * Author: Marcus Quinn & WP ALLSTARS
  * Author URI: https://www.wpallstars.com
  * License: GPL-2.0+
  * License URI: https://www.gnu.org/licenses/gpl-2.0.html
@@ -48,7 +48,7 @@ if ( ! defined( 'ABSPATH' ) ) {
 }
 
 // Define plugin constants
-define( 'FPDEN_VERSION', '1.6.3' );
+define( 'FPDEN_VERSION', '1.6.13' );
 define( 'FPDEN_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
 define( 'FPDEN_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
 define( 'FPDEN_PLUGIN_FILE', __FILE__ );
@@ -73,6 +73,13 @@ add_action( 'plugins_loaded', 'fpden_load_textdomain' );
  */
 class Fix_Plugin_Does_Not_Exist_Notices {
 
+	/**
+	 * Cached list of invalid plugins.
+	 *
+	 * @var array
+	 */
+	private $invalid_plugins = null;
+
 	/**
 	 * Constructor. Hooks into WordPress actions and filters.
 	 */
@@ -91,6 +98,9 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 
 		// Enqueue admin scripts and styles.
 		add_action( 'admin_enqueue_scripts', array( $this, 'enqueue_admin_assets' ) );
+
+		// We're no longer trying to prevent WordPress from auto-deactivating plugins
+		// as it was causing critical errors in some environments
 	}
 
 	/**
@@ -133,8 +143,8 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 			array(
 				'i18n' => array(
 					'clickToScroll' => esc_html__( 'Click here to scroll to missing plugins', 'fix-plugin-does-not-exist-notices' ),
-					'pluginMissing' => esc_html__( 'Plugin file missing', 'fix-plugin-does-not-exist-notices' ),
-					'removeReference' => esc_html__( 'Remove Reference', 'fix-plugin-does-not-exist-notices' ),
+					'pluginMissing' => esc_html__( 'File Missing', 'fix-plugin-does-not-exist-notices' ),
+					'removeNotice' => esc_html__( 'Remove Notice', 'fix-plugin-does-not-exist-notices' ),
 				),
 			)
 		);
@@ -166,7 +176,7 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 					'Name'        => $plugin_name . ' <span class="error">(File Missing)</span>',
 					/* translators: %s: Path to wp-content/plugins */
 					'Description' => sprintf(
-						__( 'This plugin is still marked as "Active" in your database — but its folder and files can\'t be found in %s. Click "Remove Reference" to permanently remove it from your active plugins list and eliminate the error notice.', 'fix-plugin-does-not-exist-notices' ),
+						__( 'This plugin is still marked as "Active" in your database — but its folder and files can\'t be found in %s. Click "Remove Notice" to permanently remove it from your active plugins list and eliminate the error notice.', 'fix-plugin-does-not-exist-notices' ),
 						'<code>/wp-content/plugins/</code>'
 					),
 					'Version'     => __( 'N/A', 'fix-plugin-does-not-exist-notices' ),
@@ -183,10 +193,10 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 	}
 
 	/**
-	 * Add the Remove Reference action link to invalid plugins.
+	 * Add the Remove Notice action link to invalid plugins.
 	 *
 	 * Filters the action links displayed for each plugin on the plugins page.
-	 * Adds a "Remove Reference" link for plugins identified as missing.
+	 * Adds a "Remove Notice" link for plugins identified as missing.
 	 *
 	 * @param array  $actions     An array of plugin action links.
 	 * @param string $plugin_file Path to the plugin file relative to the plugins directory.
@@ -201,8 +211,11 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 			return $actions;
 		}
 
-		// Check if this is a missing plugin identified by our previous filter.
-		if ( isset( $plugin_data['Name'] ) && strpos( $plugin_data['Name'], '<span class="error">(File Missing)</span>' ) !== false ) {
+		// Get our list of invalid plugins
+		$invalid_plugins = $this->get_invalid_plugins();
+
+		// Check if this plugin file is in our list of invalid plugins
+		if ( in_array( $plugin_file, $invalid_plugins, true ) ) {
 			// Clear existing actions like "Activate", "Deactivate", "Edit".
 			$actions = array();
 
@@ -211,7 +224,7 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 			$remove_url = admin_url( 'plugins.php?action=remove_reference&plugin=' . urlencode( $plugin_file ) . '&_wpnonce=' . $nonce );
 			/* translators: %s: Plugin file path */
 			$aria_label                 = sprintf( __( 'Remove reference to missing plugin %s', 'fix-plugin-does-not-exist-notices' ), esc_attr( $plugin_file ) );
-			$actions['remove_reference'] = '<a href="' . esc_url( $remove_url ) . '" class="delete" aria-label="' . $aria_label . '">' . esc_html__( 'Remove Reference', 'fix-plugin-does-not-exist-notices' ) . '</a>';
+			$actions['remove_reference'] = '<a href="' . esc_url( $remove_url ) . '" class="delete" aria-label="' . $aria_label . '">' . esc_html__( 'Remove Notice', 'fix-plugin-does-not-exist-notices' ) . '</a>';
 		}
 
 		return $actions;
@@ -299,8 +312,9 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 	/**
 	 * Display admin notices on the plugins page.
 	 *
-	 * Shows informational notices about missing plugins and feedback
-	 * messages after attempting to remove a reference.
+	 * Shows feedback messages after attempting to remove a reference.
+	 * The main informational notice is handled by JavaScript to position it
+	 * directly below the WordPress error message.
 	 *
 	 * @return void
 	 */
@@ -326,34 +340,8 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 			</div>
 			<?php
 		}
-
-		// Get invalid plugins to display the main informational notice.
-		// Note: We don't need to call get_invalid_plugins() again if enqueue_admin_assets already did,
-		// but calling it here ensures the notice shows even if assets weren't enqueued (e.g., JS disabled).
-		// Consider caching the result in a class property if performance is critical.
-		$invalid_plugins = $this->get_invalid_plugins();
-
-		// Display the main informational notice if there are missing plugins.
-		if ( ! empty( $invalid_plugins ) ) {
-			?>
-			<div class="notice notice-info is-dismissible">
-				<h3><?php esc_html_e( 'Fix Plugin Does Not Exist Notices', 'fix-plugin-does-not-exist-notices' ); ?></h3>
-				<p>
-					<strong><?php esc_html_e( 'Missing plugin files detected:', 'fix-plugin-does-not-exist-notices' ); ?></strong>
-					<?php esc_html_e( 'The plugins listed below with a', 'fix-plugin-does-not-exist-notices' ); ?>
-					<span style="color:red;">(<?php esc_html_e( 'File Missing', 'fix-plugin-does-not-exist-notices' ); ?>)</span>
-					<?php esc_html_e( 'tag no longer exist but are still referenced in your database.', 'fix-plugin-does-not-exist-notices' ); ?>
-				</p>
-				<p>
-					<strong><?php esc_html_e( 'How to fix:', 'fix-plugin-does-not-exist-notices' ); ?></strong>
-					<?php esc_html_e( 'Click the "Remove Reference" link next to each missing plugin to safely remove it from your active plugins list.', 'fix-plugin-does-not-exist-notices' ); ?>
-				</p>
-				<p><?php esc_html_e( 'This will clean up your database and remove the error notifications.', 'fix-plugin-does-not-exist-notices' ); ?></p>
-			</div>
-			<?php
-			// The JavaScript enqueued by enqueue_admin_assets() will handle adding the contextual notice
-			// near the actual WordPress error message.
-		}
+		// The main informational notice is now handled entirely by JavaScript
+		// to position it directly below the WordPress error message.
 	}
 
 	/**
@@ -372,11 +360,17 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 	 * Get a list of active plugin file paths that do not exist on the filesystem.
 	 *
 	 * Checks both single site and network active plugins based on the context.
+	 * Uses caching to avoid repeated filesystem checks.
 	 *
 	 * @return array An array of plugin file paths (relative to WP_PLUGIN_DIR) that are missing.
 	 */
 	private function get_invalid_plugins() {
-		$invalid_plugins = array();
+		// Return cached result if available
+		if ( null !== $this->invalid_plugins ) {
+			return $this->invalid_plugins;
+		}
+
+		$this->invalid_plugins = array();
 		$active_plugins  = array();
 
 		// Determine which option to check based on context (Network Admin or single site).
@@ -394,12 +388,14 @@ class Fix_Plugin_Does_Not_Exist_Notices {
 			$plugin_path = WP_PLUGIN_DIR . '/' . $plugin_file;
 			// Use validate_file to prevent directory traversal issues, although less likely here.
 			if ( validate_file( $plugin_file ) === 0 && ! file_exists( $plugin_path ) ) {
-				$invalid_plugins[] = $plugin_file;
+				$this->invalid_plugins[] = $plugin_file;
 			}
 		}
 
-		return $invalid_plugins;
+		return $this->invalid_plugins;
 	}
+
+// We've removed the prevent_auto_deactivation method as it was causing critical errors
 } // End class Fix_Plugin_Does_Not_Exist_Notices
 
 // Initialize the plugin class.

languages/fix-plugin-does-not-exist-notices.pot

@@ -2,14 +2,14 @@
 # This file is distributed under the GPL-2.0+.
 msgid ""
 msgstr ""
-"Project-Id-Version: Fix 'Plugin file does not exist.' Notices 1.6.2\n"
+"Project-Id-Version: Fix 'Plugin file does not exist.' Notices 1.6.13\n"
 "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/fix-plugin-does-not-exist-notices\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
-"POT-Creation-Date: 2024-05-15T12:00:00+00:00\n"
+"POT-Creation-Date: 2024-05-16T12:00:00+00:00\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "X-Generator: WP-CLI 2.8.1\n"
 "X-Domain: fix-plugin-does-not-exist-notices\n"

readme.txt

@@ -1,15 +1,15 @@
 === Fix 'Plugin file does not exist.' Notices ===
-Contributors: marcusquinn
-Donate link: https://www.wpallstars.com
+Contributors: marcusquinn, wpallstars
+Donate link: https://www.marcusquinn.com
 Tags: plugins, missing plugins, cleanup, error fix, admin tools, plugin file does not exist
 Requires at least: 5.0
 Tested up to: 6.4
 Requires PHP: 7.0
-Stable tag: 1.6.3
+Stable tag: 1.6.13
 License: GPL-2.0+
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
 
-Easily remove references to deleted plugins that cause "Plugin file does not exist" errors in your WordPress admin.
+Easily remove references to deleted plugins that cause "Plugin file does not exist" errors in your WordPress admin. By Marcus Quinn (marcusquinn.com) & WP ALLSTARS (wpallstars.com).
 
 == Description ==
 
@@ -89,6 +89,74 @@ Although this plugin consumes minimal disk space, and doesn't run unless you are
 
 == Changelog ==
 
+= 1.6.13 =
+* Code cleanup and optimization
+* Improved Git Updater integration
+* Fixed author display in plugin information
+* Ensured compatibility with WordPress 6.4
+
+= 1.6.12 =
+* Added WP ALLSTARS as a co-author
+* Updated author information and links
+* Added author websites to plugin description
+* Fixed issue with multiple author URLs
+
+= 1.6.11 =
+* CRITICAL FIX: Completely removed auto-deactivation prevention code that was causing fatal errors
+* Simplified plugin functionality to focus on core features only
+* Improved compatibility with various WordPress configurations
+* Ensured plugin works correctly when other plugins are deleted
+
+= 1.6.10 =
+* Fixed critical error that could occur when a plugin folder is deleted
+* Improved error handling with try/catch blocks
+* Added more specific checks for the plugins page
+* Enhanced compatibility with various WordPress configurations
+* Made the code more defensive to prevent potential issues
+
+= 1.6.9 =
+* Fixed issue with notices not appearing below WordPress error messages
+* Improved JavaScript detection of WordPress error notices
+* Prevented WordPress from automatically clearing error notices on page refresh
+* Added multiple timing attempts to ensure notices appear correctly
+* Enhanced error notice targeting for better compatibility
+
+= 1.6.8 =
+* Fixed notice positioning to appear directly below WordPress error messages
+* Improved notice width to match WordPress error messages
+* Updated explanatory text for better clarity
+* Fixed issue with notices not appearing in some cases
+* Improved JavaScript detection of WordPress error messages
+
+= 1.6.7 =
+* Fixed duplicate notices issue by removing PHP-generated notice
+* Simplified notice system to only show one notice below WordPress error
+* Ensured consistent terminology with "Remove Notice" text
+* Optimized plugin detection with caching to improve performance
+* Fixed JavaScript to correctly handle multiple error messages
+
+= 1.6.6 =
+* Fixed issue with "Remove Notice" link not appearing on missing plugin rows
+* Fixed issue with automatic removal of plugin references without user action
+* Fixed notice positioning to ensure it appears below error messages
+* Restored pointer triangle to indicate relationship with error message
+* Improved detection of missing plugins in the plugin list
+* Enhanced scroll functionality to work with all plugin types
+
+= 1.6.5 =
+* Fixed duplicate notices issue - now only one notice appears below error messages
+* Changed notice heading to "Fix Plugin Does Not Exist Notices ☝️"
+* Updated explanatory text to be more clear about the removal process
+* Changed "Remove Reference" link text to "Remove Notice" for better clarity
+* Made "(File Missing)" text bold and red for better visibility
+* Fixed scroll functionality to work with all plugin rows
+* Improved JavaScript to prevent multiple notices from appearing
+
+= 1.6.4 =
+* Updated version management to ensure consistent patch version increments
+* Improved documentation for version update process
+* Enhanced AI workflow files with detailed version increment instructions
+
 = 1.6.3 =
 * Fixed Git Updater repository URLs to use full repository paths
 * Corrected Update URI configuration for proper update detection
@@ -191,6 +259,15 @@ Although this plugin consumes minimal disk space, and doesn't run unless you are
 
 == Upgrade Notice ==
 
+= 1.6.13 =
+Code cleanup, improved Git Updater integration, and ensured compatibility with WordPress 6.4.
+
+= 1.6.12 =
+Added WP ALLSTARS as a co-author and updated author information.
+
+= 1.6.11 =
+URGENT CRITICAL FIX: Completely removes code that was causing fatal errors. If you're experiencing the "critical error" message, this update will resolve it.
+
 = 1.6.3 =
 Fixed Git Updater repository URLs and updated organization naming for consistent branding across all platforms!