From 613c4f43b65d9267495de820abd3b8e5b732ac9e Mon Sep 17 00:00:00 2001
From: Marcus Quinn <6428977+marcusquinn@users.noreply.github.com>
Date: Fri, 11 Apr 2025 22:48:47 +0100
Subject: [PATCH 1/7] Refactor: Enqueue assets, add docblocks, bump version to
1.5.0
---
assets/css/admin-styles.css | 28 ++
assets/js/admin-scripts.js | 81 ++++
fix-plugin-does-not-exist-notices.php | 632 ++++++++++++++------------
3 files changed, 439 insertions(+), 302 deletions(-)
create mode 100644 assets/css/admin-styles.css
create mode 100644 assets/js/admin-scripts.js
diff --git a/assets/css/admin-styles.css b/assets/css/admin-styles.css
new file mode 100644
index 0000000..c889c41
--- /dev/null
+++ b/assets/css/admin-styles.css
@@ -0,0 +1,28 @@
+.prc-notice {
+ border-left: 4px solid #ffba00;
+ background-color: #fff8e5;
+ padding: 10px 12px;
+ margin: 5px 0 15px;
+ font-size: 14px;
+ position: relative;
+}
+.prc-notice h3 {
+ margin-top: 0;
+ color: #826200;
+}
+.prc-notice::before {
+ content: "";
+ position: absolute;
+ top: -10px;
+ left: 20px;
+ width: 0;
+ height: 0;
+ border-left: 10px solid transparent;
+ border-right: 10px solid transparent;
+ border-bottom: 10px solid #fff8e5;
+}
+
+/* Style for highlighting the missing plugin row */
+tr.inactive.prc-highlight-missing {
+ background-color: #fff8e5 !important; /* Use !important to override default styles */
+}
diff --git a/assets/js/admin-scripts.js b/assets/js/admin-scripts.js
new file mode 100644
index 0000000..cd67c38
--- /dev/null
+++ b/assets/js/admin-scripts.js
@@ -0,0 +1,81 @@
+(function() {
+ // Function to inject our notice
+ function injectNotice() {
+ // Find all notification containers first
+ var noticeContainers = document.querySelectorAll('.notice, .error, .updated');
+
+ // Find all error notifications about missing plugins
+ noticeContainers.forEach(function(notice) {
+ if (notice.textContent.includes('Plugin file does not exist') ||
+ notice.textContent.includes('has been deactivated due to an error')) {
+
+ // Check if we already added our notice
+ if (notice.nextElementSibling && notice.nextElementSibling.classList.contains('prc-notice')) {
+ return;
+ }
+
+ // Create our custom notice
+ var ourNotice = document.createElement('div');
+ ourNotice.className = 'prc-notice';
+
+ // Add content (using localized strings passed via wp_localize_script if needed, but simple for now)
+ ourNotice.innerHTML = '👉 Fix Plugin Does Not Exist Notices Can Fix This
' +
+ 'To remove the above error notification, scroll down to find the plugin marked with "(File Missing)" and click its "Remove Reference" link.
' +
+ 'This will permanently remove the missing plugin reference from your database.
' +
+ 'Click here to scroll to the missing plugin
';
+
+ // Insert our notice right after the error
+ notice.parentNode.insertBefore(ourNotice, notice.nextSibling);
+
+ // Add scroll behavior
+ var scrollLink = document.getElementById('prc-scroll-to-plugin');
+ if (scrollLink) {
+ scrollLink.addEventListener('click', function(e) {
+ e.preventDefault();
+ var missingPlugins = document.querySelectorAll('tr.inactive:not(.plugin-update-tr)');
+ for (var i = 0; i < missingPlugins.length; i++) {
+ if (missingPlugins[i].textContent.includes('(File Missing)')) {
+ // Add a class for highlighting instead of direct style manipulation
+ missingPlugins[i].classList.add('prc-highlight-missing');
+ missingPlugins[i].scrollIntoView({ behavior: 'smooth', block: 'center' });
+ // Optional: Remove highlight after a delay
+ setTimeout(function() {
+ missingPlugins[i].classList.remove('prc-highlight-missing');
+ }, 3000); // Remove highlight after 3 seconds
+ return;
+ }
+ }
+ });
+ }
+ }
+ });
+ }
+
+ // Try to inject notices on multiple events to ensure it works
+ document.addEventListener('DOMContentLoaded', function() {
+ injectNotice();
+
+ // Also set up a MutationObserver to watch for dynamically added notices
+ var observer = new MutationObserver(function(mutations) {
+ mutations.forEach(function(mutation) {
+ if (mutation.addedNodes && mutation.addedNodes.length > 0) {
+ // Check if added nodes are notices or contain notices
+ mutation.addedNodes.forEach(function(node) {
+ if (node.nodeType === 1 && (node.matches('.notice, .error, .updated') || node.querySelector('.notice, .error, .updated'))) {
+ injectNotice();
+ }
+ });
+ }
+ });
+ });
+
+ // Start observing the body for changes in children
+ observer.observe(document.body, { childList: true, subtree: true });
+ });
+
+ // Backup attempt with window.onload (less reliable than DOMContentLoaded but good fallback)
+ window.addEventListener('load', function() {
+ setTimeout(injectNotice, 500); // Delay slightly to ensure dynamic content is loaded
+ });
+
+})();
diff --git a/fix-plugin-does-not-exist-notices.php b/fix-plugin-does-not-exist-notices.php
index 3f55a49..c7f44ea 100644
--- a/fix-plugin-does-not-exist-notices.php
+++ b/fix-plugin-does-not-exist-notices.php
@@ -10,7 +10,7 @@
* @wordpress-plugin
* Plugin Name: Fix 'Plugin file does not exist.' Notices
* Description: Adds missing plugins to the plugins list with a "Remove Reference" link so you can permanently clean up invalid plugin entries and remove error notices.
- * Version: 1.4.2
+ * Version: 1.5.0
* Author: Marcus Quinn
* Author URI: https://www.wpallstars.com
* License: GPL-2.0+
@@ -34,310 +34,338 @@
* along with this plugin. If not, see https://www.gnu.org/licenses/gpl-2.0.html.
*/
-// Exit if accessed directly
-if (!defined('ABSPATH')) {
+// Exit if accessed directly.
+if ( ! defined( 'ABSPATH' ) ) {
exit;
}
+/**
+ * Main class for the plugin.
+ */
class Fix_Plugin_Does_Not_Exist_Notices {
- public function __construct() {
- // Add our plugin to the plugins list
- add_filter('all_plugins', array($this, 'add_missing_plugins_references'));
-
- // Add our action link to the plugins list
- add_filter('plugin_action_links', array($this, 'add_remove_reference_action'), 20, 4);
-
- // Handle the remove reference action
- add_action('admin_init', array($this, 'handle_remove_reference'));
-
- // Add admin notices for operation feedback
- add_action('admin_notices', array($this, 'admin_notices'));
- }
-
- /**
- * Find and add invalid plugin references to the plugins list
- */
- public function add_missing_plugins_references($plugins) {
- // Only run on the plugins page
- if (!$this->is_plugins_page()) {
- return $plugins;
- }
- // Get active plugins that don't exist
- $invalid_plugins = $this->get_invalid_plugins();
-
- // Add each invalid plugin to the plugin list
- foreach ($invalid_plugins as $plugin_path) {
- if (!isset($plugins[$plugin_path])) {
- $plugin_name = basename($plugin_path);
- $plugins[$plugin_path] = array(
- 'Name' => $plugin_name . ' (File Missing)',
- 'Description' => 'This plugin is still marked as "Active" in your database — but its folder and files can\'t be found in /wp-content/plugins/. Click "Remove Reference" to permanently remove it from your active plugins list and eliminate the error notice.',
- 'Version' => 'N/A',
- 'Author' => '',
- 'PluginURI' => '',
- 'AuthorURI' => '',
- 'Title' => $plugin_name . ' (Missing)',
- 'AuthorName' => ''
- );
- }
- }
-
- return $plugins;
- }
-
- /**
- * Add the Remove Reference action link to invalid plugins
- */
- public function add_remove_reference_action($actions, $plugin_file, $plugin_data, $context) {
- // Only run on the plugins page
- if (!$this->is_plugins_page()) {
- return $actions;
- }
-
- // Check if this is a missing plugin
- if (isset($plugin_data['Name']) && strpos($plugin_data['Name'], '(File Missing)') !== false) {
- // Clear existing actions
- $actions = array();
-
- // Add our action
- $nonce = wp_create_nonce('remove_plugin_reference_' . $plugin_file);
- $remove_url = admin_url('plugins.php?action=remove_reference&plugin=' . urlencode($plugin_file) . '&_wpnonce=' . $nonce);
- $actions['remove_reference'] = 'Remove Reference';
- }
-
- return $actions;
- }
-
- /**
- * Handle the remove reference action
- */
- public function handle_remove_reference() {
- // Check if we're removing a reference
- if (!isset($_GET['action']) || $_GET['action'] !== 'remove_reference' || !isset($_GET['plugin'])) {
- return;
- }
-
- // Verify permissions
- if (!current_user_can('activate_plugins')) {
- wp_die(__('You do not have sufficient permissions to perform this action.', 'fix-plugin-does-not-exist-notices'));
- }
-
- // Get the plugin file
- $plugin_file = isset($_GET['plugin']) ? $_GET['plugin'] : '';
-
- // Verify nonce
- check_admin_referer('remove_plugin_reference_' . $plugin_file);
-
- // Remove the plugin reference
- $success = $this->remove_plugin_reference($plugin_file);
-
- // Redirect back to plugins page with a message
- $redirect = admin_url('plugins.php');
- $redirect = add_query_arg($success ? 'reference_removed' : 'reference_removal_failed', '1', $redirect);
- wp_redirect($redirect);
- exit;
- }
-
- /**
- * Remove a plugin reference from the active plugins
- */
- public function remove_plugin_reference($plugin_file) {
- $success = false;
-
- // Handle multisite network admin
- if (is_multisite() && is_network_admin()) {
- $active_plugins = get_site_option('active_sitewide_plugins', array());
- if (isset($active_plugins[$plugin_file])) {
- unset($active_plugins[$plugin_file]);
- $success = update_site_option('active_sitewide_plugins', $active_plugins);
- }
- }
- // Handle single site or multisite subsite
- else {
- $active_plugins = get_option('active_plugins', array());
- $key = array_search($plugin_file, $active_plugins);
- if ($key !== false) {
- unset($active_plugins[$key]);
- $active_plugins = array_values($active_plugins); // Re-index array
- $success = update_option('active_plugins', $active_plugins);
- }
- }
-
- return $success;
- }
-
- /**
- * Display admin notices
- */
- public function admin_notices() {
- // Only run on the plugins page
- if (!$this->is_plugins_page()) {
- return;
- }
-
- // Get invalid plugins
- $invalid_plugins = $this->get_invalid_plugins();
-
- // Create a highlighted notice immediately after WordPress error messages
- if (!empty($invalid_plugins)) {
- // Add a notice specifically targeting the WordPress error notification
- // Use admin_head to ensure it runs early in the page load process
- add_action('admin_head', function() use ($invalid_plugins) {
- ?>
-
-
- ';
- echo 'Fix Plugin Does Not Exist Notices
';
- echo 'Missing plugin files detected: The plugins listed below with (File Missing) tag no longer exist but are still referenced in your database.
';
- echo 'How to fix: Click the "Remove Reference" link next to each missing plugin to safely remove it from your active plugins list.
';
- echo 'This will clean up your database and remove the error notifications.
';
- echo '';
- }
-
- // Show success message
- if (isset($_GET['reference_removed']) && $_GET['reference_removed'] === '1') {
- echo 'Plugin reference removed successfully.
Failed to remove plugin reference. The plugin may already have been removed.
/wp-content/plugins/'
+ ),
+ 'Version' => __( 'N/A', 'fix-plugin-does-not-exist-notices' ),
+ 'Author' => '',
+ 'PluginURI' => '',
+ 'AuthorURI' => '',
+ 'Title' => $plugin_name . ' (' . __( 'Missing', 'fix-plugin-does-not-exist-notices' ) . ')',
+ 'AuthorName' => '',
+ );
+ }
+ }
+
+ return $plugins;
+ }
+
+ /**
+ * Add the Remove Reference action link to invalid plugins.
+ *
+ * Filters the action links displayed for each plugin on the plugins page.
+ * Adds a "Remove Reference" link for plugins identified as missing.
+ *
+ * @param array $actions An array of plugin action links.
+ * @param string $plugin_file Path to the plugin file relative to the plugins directory.
+ * @param array $plugin_data An array of plugin data.
+ * @param string $context The plugin context (e.g., 'all', 'active', 'inactive').
+ * @return array The potentially modified array of plugin action links.
+ */
+ public function add_remove_reference_action( $actions, $plugin_file, $plugin_data, $context ) {
+ // Only run on the plugins page.
+ if ( ! $this->is_plugins_page() ) {
+ return $actions;
+ }
+
+ // Check if this is a missing plugin identified by our previous filter.
+ if ( isset( $plugin_data['Name'] ) && strpos( $plugin_data['Name'], '(File Missing)' ) !== false ) {
+ // Clear existing actions like "Activate", "Deactivate", "Edit".
+ $actions = array();
+
+ // Add our custom action.
+ $nonce = wp_create_nonce( 'remove_plugin_reference_' . $plugin_file );
+ $remove_url = admin_url( 'plugins.php?action=remove_reference&plugin=' . urlencode( $plugin_file ) . '&_wpnonce=' . $nonce );
+ /* translators: %s: Plugin file path */
+ $aria_label = sprintf( __( 'Remove reference to missing plugin %s', 'fix-plugin-does-not-exist-notices' ), esc_attr( $plugin_file ) );
+ $actions['remove_reference'] = '' . esc_html__( 'Remove Reference', 'fix-plugin-does-not-exist-notices' ) . '';
+ }
+
+ return $actions;
+ }
+
+ /**
+ * Handle the remove reference action triggered by the link.
+ *
+ * Checks for the correct action, verifies nonce and permissions,
+ * calls the removal function, and redirects back to the plugins page.
+ *
+ * @return void
+ */
+ public function handle_remove_reference() {
+ // Check if our specific action is being performed.
+ if ( ! isset( $_GET['action'] ) || 'remove_reference' !== $_GET['action'] || ! isset( $_GET['plugin'] ) ) {
+ return;
+ }
+
+ // Verify user permissions.
+ if ( ! current_user_can( 'activate_plugins' ) ) {
+ wp_die( esc_html__( 'You do not have sufficient permissions to perform this action.', 'fix-plugin-does-not-exist-notices' ) );
+ }
+
+ // Sanitize and get the plugin file path.
+ $plugin_file = isset( $_GET['plugin'] ) ? sanitize_text_field( wp_unslash( $_GET['plugin'] ) ) : '';
+ if ( empty( $plugin_file ) ) {
+ wp_die( esc_html__( 'Invalid plugin specified.', 'fix-plugin-does-not-exist-notices' ) );
+ }
+
+ // Verify nonce for security.
+ check_admin_referer( 'remove_plugin_reference_' . $plugin_file );
+
+ // Attempt to remove the plugin reference.
+ $success = $this->remove_plugin_reference( $plugin_file );
+
+ // Prepare redirect URL with feedback query args.
+ $redirect_url = admin_url( 'plugins.php' );
+ $redirect_url = add_query_arg( $success ? 'reference_removed' : 'reference_removal_failed', '1', $redirect_url );
+
+ // Redirect and exit.
+ wp_safe_redirect( $redirect_url );
+ exit;
+ }
+
+ /**
+ * Remove a plugin reference from the active plugins list in the database.
+ *
+ * Handles both single site and multisite network activated plugins.
+ *
+ * @param string $plugin_file The plugin file path to remove.
+ * @return bool True on success, false on failure or if the plugin wasn't found.
+ */
+ public function remove_plugin_reference( $plugin_file ) {
+ $success = false;
+
+ // Ensure plugin file path is provided.
+ if ( empty( $plugin_file ) ) {
+ return false;
+ }
+
+ // Handle multisite network admin context.
+ if ( is_multisite() && is_network_admin() ) {
+ $active_plugins = get_site_option( 'active_sitewide_plugins', array() );
+ // Network active plugins are stored as key => timestamp.
+ if ( isset( $active_plugins[ $plugin_file ] ) ) {
+ unset( $active_plugins[ $plugin_file ] );
+ $success = update_site_option( 'active_sitewide_plugins', $active_plugins );
+ }
+ } else { // Handle single site or non-network admin context.
+ $active_plugins = get_option( 'active_plugins', array() );
+ // Single site active plugins are stored as an indexed array.
+ $key = array_search( $plugin_file, $active_plugins, true ); // Use strict comparison.
+ if ( false !== $key ) {
+ unset( $active_plugins[ $key ] );
+ // Re-index the array numerically.
+ $active_plugins = array_values( $active_plugins );
+ $success = update_option( 'active_plugins', $active_plugins );
+ }
+ }
+
+ return $success;
+ }
+
+ /**
+ * Display admin notices on the plugins page.
+ *
+ * Shows informational notices about missing plugins and feedback
+ * messages after attempting to remove a reference.
+ *
+ * @return void
+ */
+ public function admin_notices() {
+ // Only run on the plugins page.
+ if ( ! $this->is_plugins_page() ) {
+ return;
+ }
+
+ // Check for feedback messages from the remove action.
+ if ( isset( $_GET['reference_removed'] ) && '1' === $_GET['reference_removed'] ) {
+ ?>
+
+
+
+ get_invalid_plugins();
+
+ // Display the main informational notice if there are missing plugins.
+ if ( ! empty( $invalid_plugins ) ) {
+ ?>
+
+
+
+
+
+ ()
+
+
+
+
+
+
+
+