marcus/wpa-superstar-plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify loading indicators with a single spinner next to Loading text

Browse Source
This commit is contained in:
Marcus Quinn
2025-03-16 18:50:28 +00:00
parent a28f3ed267
commit c704dbecd8
2 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
admin/js/wp-allstars-admin.js
View File

@ -155,7 +155,7 @@ jQuery(document).ready(function($) {
// Function to load plugins // Function to load plugins
function loadPlugins(category) { function loadPlugins(category) {
var $container = $('#wpa-plugin-list'); var $container = $('#wpa-plugin-list');
var $loadingOverlay = $('<div class="wp-allstars-loading-overlay"><span class="spinner is-active"></span><p>Loading plugins...</p></div>'); var $loadingOverlay = $('<div class="wp-allstars-loading-overlay"><div style="display: flex; align-items: center; justify-content: center;"><span class="spinner is-active" style="margin-right: 10px;"></span><p>Loading plugins...</p></div></div>');
// Show loading overlay // Show loading overlay
$container.css('position', 'relative').append($loadingOverlay); $container.css('position', 'relative').append($loadingOverlay);
@ -183,13 +183,7 @@ jQuery(document).ready(function($) {
// Initialize plugin action buttons // Initialize plugin action buttons
initPluginActions(); initPluginActions();
// Show standard WordPress spinner in each plugin card // Individual plugin card spinners have been removed
$('.plugin-card .plugin-spinner').addClass('is-active').show();
// Hide spinners after all plugin details have loaded
setTimeout(function() {
$('.plugin-card .plugin-spinner').removeClass('is-active').hide();
}, 1000);
} else { } else {
// Show error message // Show error message
$container.html('<div class="notice notice-error"><p>' + response.data + '</p></div>'); $container.html('<div class="notice notice-error"><p>' + response.data + '</p></div>');

11
admin/settings.php
View File

@ -319,7 +319,6 @@ function wp_allstars_generate_plugin_cards($plugins) {
<div class="name column-name"> <div class="name column-name">
<h3> <h3>
<?php echo esc_html($plugin->name); ?> <?php echo esc_html($plugin->name); ?>
<img src="<?php echo esc_url(admin_url('images/spinner.gif')); ?>" class="plugin-spinner spinner" alt="">
</h3> </h3>
</div> </div>
<div class="action-links"> <div class="action-links">
@ -627,7 +626,7 @@ function wp_allstars_settings_page() {
if ($("#wpa-plugin-list").length && $("#wpa-plugin-list").is(":empty")) { if ($("#wpa-plugin-list").length && $("#wpa-plugin-list").is(":empty")) {
var category = "' . esc_js($active_category) . '"; var category = "' . esc_js($active_category) . '";
var $container = $("#wpa-plugin-list"); var $container = $("#wpa-plugin-list");
var $loadingOverlay = $("<div class=\"wp-allstars-loading-overlay\"><span class=\"spinner is-active\"></span><p>Loading plugins...</p></div>"); var $loadingOverlay = $("<div class=\"wp-allstars-loading-overlay\"><div style=\"display: flex; align-items: center; justify-content: center;\"><span class=\"spinner is-active\" style=\"margin-right: 10px;\"></span><p>Loading plugins...</p></div></div>");
// Show loading overlay // Show loading overlay
$container.css("position", "relative").append($loadingOverlay); $container.css("position", "relative").append($loadingOverlay);
@ -650,13 +649,7 @@ function wp_allstars_settings_page() {
initPluginActions(); initPluginActions();
} }
// Show standard WordPress spinner in each plugin card // Spinners have been removed from individual cards
$(".plugin-card .plugin-spinner").addClass("is-active").show();
// Hide spinners after all plugin details have loaded
setTimeout(function() {
$(".plugin-card .plugin-spinner").removeClass("is-active").hide();
}, 1000);
} else { } else {
$container.html("<div class=\"notice notice-error\"><p>" + response.data + "</p></div>"); $container.html("<div class=\"notice notice-error\"><p>" + response.data + "</p></div>");
} }