From 9a0e94b29e1498acebd0e2ec688b7c346a4dd0f4 Mon Sep 17 00:00:00 2001
From: Marcus Quinn <marcus@agentdesign.co.uk>
Date: Sat, 15 Mar 2025 04:06:43 +0000
Subject: [PATCH] Fix tab navigation and settings dropdown styling

- Improve navigation tab styles to match WordPress core\n- Fix settings dropdown visibility and transitions\n- Enhance expand/collapse button styling\n- Add proper spacing and layout for settings
---
 admin/css/wp-allstars-admin.css | 140 ++++++++++++++++++--------------
 1 file changed, 78 insertions(+), 62 deletions(-)

diff --git a/admin/css/wp-allstars-admin.css b/admin/css/wp-allstars-admin.css
index 20bb96c..09840ec 100644
--- a/admin/css/wp-allstars-admin.css
+++ b/admin/css/wp-allstars-admin.css
@@ -38,39 +38,42 @@
 }
 
 /* Navigation Tabs */
-.wp-allstars-nav {
-    margin-bottom: 20px;
-}
-
-.wp-allstars-nav .nav-tab-wrapper {
-    border-bottom: 1px solid #c3c4c7;
-    padding-top: 0;
+.nav-tab-wrapper {
     margin: 0;
+    padding-top: 9px;
+    padding-bottom: 0;
+    line-height: inherit;
+    border-bottom: 1px solid #c3c4c7;
 }
 
-.wp-allstars-nav .nav-tab {
-    font-size: 14px;
-    padding: 10px 15px;
-    margin-left: 0;
-    margin-right: 4px;
+.nav-tab {
+    float: left;
     border: 1px solid #c3c4c7;
     border-bottom: none;
-    background: #f0f0f1;
+    margin-left: 0.5em;
+    padding: 5px 10px;
+    font-size: 14px;
+    line-height: 1.71428571;
+    font-weight: 600;
+    background: #dcdcde;
     color: #50575e;
     text-decoration: none;
     white-space: nowrap;
 }
 
-.wp-allstars-nav .nav-tab:hover {
-    background: #fff;
+.nav-tab:hover,
+.nav-tab:focus {
+    background-color: #fff;
     color: #1d2327;
 }
 
-.wp-allstars-nav .nav-tab-active {
-    background: #fff;
-    color: #1d2327;
-    border-bottom: 1px solid #fff;
-    margin-bottom: -1px;
+.nav-tab-active,
+.nav-tab-active:focus,
+.nav-tab-active:focus:active,
+.nav-tab-active:hover {
+    border-bottom: 1px solid #f0f0f1;
+    background: #f0f0f1;
+    color: #000;
 }
 
 /* Toggle Switches */
@@ -171,55 +174,26 @@ input:checked + .wp-toggle-slider:before {
     width: 100%;
 }
 
+/* Settings Dropdown */
 .wp-allstars-toggle-settings {
+    display: none;
     margin-top: 15px;
-    padding-top: 15px;
-    border-top: 1px solid #ddd;
+    padding: 15px;
+    background: #f9f9f9;
+    border: 1px solid #ddd;
+    border-radius: 4px;
+}
+
+.wp-allstars-toggle-settings.is-open {
+    display: block;
 }
 
 .wp-allstars-setting-row {
-    margin-bottom: 20px;
+    margin-bottom: 15px;
 }
 
-/* Expand/Collapse Button */
-.wp-allstars-expand-settings {
-    background: none;
-    border: none;
-    padding: 4px;
-    cursor: pointer;
-    color: #787c82;
-    transition: color .15s ease-in-out;
-}
-
-.wp-allstars-expand-settings:hover {
-    color: #1d2327;
-}
-
-.wp-allstars-expand-settings .dashicons {
-    width: 20px;
-    height: 20px;
-    font-size: 20px;
-    transition: transform .15s ease-in-out;
-}
-
-.wp-allstars-expand-settings[aria-expanded="true"] .dashicons {
-    transform: rotate(180deg);
-}
-
-/* Form Elements */
-.wp-allstars-setting-row input[type="text"],
-.wp-allstars-setting-row input[type="number"],
-.wp-allstars-setting-row textarea {
-    width: 100%;
-    max-width: 400px;
-    padding: 8px;
-    border: 1px solid #ddd;
-    border-radius: 4px;
-    margin-top: 5px;
-}
-
-.wp-allstars-setting-row textarea {
-    min-height: 100px;
+.wp-allstars-setting-row:last-child {
+    margin-bottom: 0;
 }
 
 .wp-allstars-setting-row label {
@@ -228,6 +202,48 @@ input:checked + .wp-toggle-slider:before {
     font-weight: 500;
 }
 
+.wp-allstars-setting-row input[type="text"],
+.wp-allstars-setting-row input[type="number"],
+.wp-allstars-setting-row select {
+    width: 100%;
+    max-width: 400px;
+}
+
+.wp-allstars-expand-settings {
+    display: flex;
+    align-items: center;
+    gap: 5px;
+    padding: 4px 8px;
+    background: #f0f0f1;
+    border: 1px solid #c3c4c7;
+    border-radius: 3px;
+    cursor: pointer;
+    transition: all 0.2s ease;
+}
+
+.wp-allstars-expand-settings:hover {
+    background: #fff;
+    border-color: #8c8f94;
+}
+
+.wp-allstars-expand-settings .dashicons {
+    font-size: 16px;
+    width: 16px;
+    height: 16px;
+    transition: transform 0.2s ease;
+}
+
+.wp-allstars-expand-settings[aria-expanded="true"] .dashicons {
+    transform: rotate(180deg);
+}
+
+/* Clear floats after tabs */
+.nav-tab-wrapper::after {
+    content: "";
+    display: table;
+    clear: both;
+}
+
 /* Loading Overlay */
 .wp-allstars-loading-overlay {
     position: fixed;