marcus/wpa-superstar-plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix accordion behavior to properly stay open/closed following WordPress patterns

Browse Source
This commit is contained in:
Marcus Quinn
2025-03-16 02:32:46 +00:00
parent cf3235984a
commit 4a860c416c
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
admin/settings.php
View File

@ -671,7 +671,7 @@ function wp_allstars_settings_page() {
<span class="wp-toggle-slider"></span> <span class="wp-toggle-slider"></span>
</div> </div>
<?php esc_html_e('Enable Auto Upload Images', 'wp-allstars'); ?> <?php esc_html_e('Enable Auto Upload Images', 'wp-allstars'); ?>
</label> </label>
<button type="button" class="wp-allstars-expand-settings" aria-expanded="false"> <button type="button" class="wp-allstars-expand-settings" aria-expanded="false">
<span class="dashicons dashicons-arrow-down-alt2"></span> <span class="dashicons dashicons-arrow-down-alt2"></span>
</button> </button>
@ -742,26 +742,27 @@ function wp_allstars_settings_page() {
<script> <script>
jQuery(document).ready(function($) { jQuery(document).ready(function($) {
// Set initial state // Handle accordion functionality
$('.wp-allstars-toggle-settings').hide();
$('.wp-allstars-expand-settings').on('click', function(e) { $('.wp-allstars-expand-settings').on('click', function(e) {
e.preventDefault(); e.preventDefault();
e.stopPropagation();
var $button = $(this); var $button = $(this);
var $panel = $button.closest('.wp-allstars-toggle').find('.wp-allstars-toggle-settings'); var $panel = $button.closest('.wp-allstars-toggle').find('.wp-allstars-toggle-settings');
var $icon = $button.find('.dashicons'); var $icon = $button.find('.dashicons');
// Toggle panel visibility
$panel.stop().slideToggle(200);
// Toggle aria-expanded
var isExpanded = $button.attr('aria-expanded') === 'true'; var isExpanded = $button.attr('aria-expanded') === 'true';
// Toggle aria state
$button.attr('aria-expanded', !isExpanded); $button.attr('aria-expanded', !isExpanded);
// Rotate icon // Rotate icon
$icon.css('transform', !isExpanded ? 'rotate(180deg)' : ''); $icon.css('transform', !isExpanded ? 'rotate(180deg)' : '');
// Toggle panel visibility with animation
if (!isExpanded) {
$panel.css('display', 'block').hide().slideDown(200);
} else {
$panel.slideUp(200);
}
}); });
}); });
</script> </script>
@ -1304,14 +1305,14 @@ function wp_allstars_settings_page() {
<div class="wp-allstars-settings-grid"> <div class="wp-allstars-settings-grid">
<!-- Lazy load toggle removed --> <!-- Lazy load toggle removed -->
</div> </div>
</div> </div>
<?php elseif ($active_tab == 'advanced'): ?> <?php elseif ($active_tab == 'advanced'): ?>
<div class="wp-allstars-settings-section"> <div class="wp-allstars-settings-section">
<div class="wp-allstars-settings-grid"> <div class="wp-allstars-settings-grid">
<!-- Minification toggles removed --> <!-- Minification toggles removed -->
</div> </div>
</div> </div>
<?php endif; ?> <?php endif; ?>
</div> </div>
</div> </div>
</div> </div>