Fix toggle switch and chevron behavior, improve layout

This commit is contained in:
Marcus Quinn
2025-03-16 03:05:43 +00:00
parent 10dc0e2d72
commit 374bedbede
3 changed files with 64 additions and 89 deletions

View File

@ -88,9 +88,8 @@
position: relative; position: relative;
display: inline-block; display: inline-block;
width: 40px; width: 40px;
height: 20px; height: 24px;
margin-right: 12px; flex-shrink: 0;
cursor: pointer;
} }
.wp-toggle-switch input { .wp-toggle-switch input {
@ -146,11 +145,10 @@ input:checked + .wp-toggle-slider:before {
/* Toggle Sections */ /* Toggle Sections */
.wp-allstars-toggle { .wp-allstars-toggle {
background: #fff; background: #fff;
border: 1px solid #ddd; border: 1px solid #ccc;
border-radius: 8px; border-radius: 8px;
margin-bottom: 15px; margin-bottom: 15px;
box-shadow: 0 1px 3px rgba(0,0,0,0.1); position: relative;
transition: all 0.2s ease;
} }
.wp-allstars-toggle:hover { .wp-allstars-toggle:hover {
@ -159,15 +157,38 @@ input:checked + .wp-toggle-slider:before {
} }
.wp-allstars-toggle-header { .wp-allstars-toggle-header {
padding: 24px; padding: 15px;
cursor: pointer; cursor: pointer;
user-select: none; position: relative;
}
.wp-allstars-toggle-header::after {
content: '';
position: absolute;
right: 15px;
top: 50%;
transform: translateY(-50%);
width: 24px;
height: 24px;
background: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M7.41 8.59L12 13.17l4.59-4.58L18 10l-6 6-6-6 1.41-1.41z"/></svg>') no-repeat center;
background-size: 24px;
transition: transform 0.3s ease;
}
.wp-allstars-toggle-header[aria-expanded="true"]::after {
transform: translateY(-50%) rotate(180deg);
} }
.wp-allstars-toggle-main { .wp-allstars-toggle-main {
display: flex; display: flex;
align-items: center; align-items: center;
justify-content: space-between; justify-content: space-between;
padding-right: 40px;
}
.wp-allstars-toggle-left {
display: flex;
align-items: center;
gap: 10px; gap: 10px;
} }
@ -181,6 +202,7 @@ input:checked + .wp-toggle-slider:before {
color: #1d2327; color: #1d2327;
line-height: 1.4; line-height: 1.4;
cursor: default; cursor: default;
pointer-events: none;
} }
.wp-allstars-expand-settings { .wp-allstars-expand-settings {
@ -239,21 +261,6 @@ input:checked + .wp-toggle-slider:before {
outline: 2px solid transparent; outline: 2px solid transparent;
} }
/* Add chevron icon using pseudo-element */
.wp-allstars-toggle-header::after {
content: "";
display: block;
width: 20px;
height: 20px;
background: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M17.5 11.6L12 16l-5.5-4.4.9-1.2L12 14l4.5-3.6 1 1.2z" fill="%232271b1"/></svg>') no-repeat center;
transition: transform 0.2s ease;
background-size: 20px;
}
.wp-allstars-toggle-header[aria-expanded="true"]::after {
transform: rotate(180deg);
}
/* Clear floats after tabs */ /* Clear floats after tabs */
.nav-tab-wrapper::after { .nav-tab-wrapper::after {
content: ""; content: "";

View File

@ -31,37 +31,35 @@ jQuery(document).ready(function($) {
}); });
} }
// Toggle switch functionality - stop propagation to prevent panel toggle // Handle toggle switch clicks
$('.wp-toggle-switch').on('click', function(e) { $('.wp-toggle-switch').on('click', function(e) {
e.stopPropagation(); // Prevent the click from bubbling to the header e.stopPropagation();
}); });
$('.wp-allstars-toggle input[type="checkbox"]').on('change', function(e) { // Handle checkbox changes
e.stopPropagation(); // Prevent the change from bubbling to the header $('.wp-toggle-switch input[type="checkbox"]').on('change', function(e) {
var $input = $(this); e.stopPropagation();
var option = $input.attr('name'); });
var value = $input.is(':checked') ? 1 : 0;
$.ajax({ // Handle panel toggle
url: ajaxurl, $('.wp-allstars-toggle-header').on('click', function(e) {
type: 'POST', if (!$(e.target).closest('.wp-toggle-switch').length) {
data: { var $settings = $(this).closest('.wp-allstars-toggle').find('.wp-allstars-toggle-settings');
action: 'wp_allstars_update_option', var isExpanded = $(this).attr('aria-expanded') === 'true';
option: option,
value: value, $(this).attr('aria-expanded', !isExpanded);
nonce: wpAllstars.nonce $settings.slideToggle();
}, }
success: function(response) { });
if (response.success) {
showNotification('Saved'); // Set initial state
} else { $('.wp-allstars-toggle-header').each(function() {
showNotification('Error saving settings', true); var $settings = $(this).closest('.wp-allstars-toggle').find('.wp-allstars-toggle-settings');
} var isExpanded = $(this).attr('aria-expanded') === 'true';
},
error: function() { if (!isExpanded) {
showNotification('Error saving settings', true); $settings.hide();
} }
});
}); });
// Handle text, number, and textarea inputs // Handle text, number, and textarea inputs
@ -80,37 +78,6 @@ jQuery(document).ready(function($) {
}); });
}); });
// Initialize accordion state
$('.wp-allstars-toggle-header').each(function() {
var $header = $(this);
var $panel = $header.closest('.wp-allstars-toggle').find('.wp-allstars-toggle-settings');
var isExpanded = $header.attr('aria-expanded') === 'true';
// Set initial state
if (isExpanded) {
$panel.show();
} else {
$panel.hide();
}
});
// Handle accordion functionality
$('.wp-allstars-toggle-header').on('click', function(e) {
var $header = $(this);
var $panel = $header.closest('.wp-allstars-toggle').find('.wp-allstars-toggle-settings');
var isExpanded = $header.attr('aria-expanded') === 'true';
// Toggle state
$header.attr('aria-expanded', !isExpanded);
// Toggle panel with animation
if (!isExpanded) {
$panel.slideDown(200);
} else {
$panel.slideUp(200);
}
});
// Handle form submission // Handle form submission
$('form').on('submit', function() { $('form').on('submit', function() {
showNotification('Saved'); showNotification('Saved');
@ -145,10 +112,11 @@ jQuery(document).ready(function($) {
$.ajax({ $.ajax({
url: ajaxurl, url: ajaxurl,
type: 'POST',
data: { data: {
action: 'wp_allstars_get_plugins', action: 'wp_allstars_get_plugins',
category: category || 'minimal', category: category || 'minimal',
_ajax_nonce: wpAllstars.nonce _wpnonce: wpAllstars.nonce
}, },
success: function(response) { success: function(response) {
if (response.success) { if (response.success) {
@ -179,9 +147,10 @@ jQuery(document).ready(function($) {
$.ajax({ $.ajax({
url: ajaxurl, url: ajaxurl,
type: 'POST',
data: { data: {
action: 'wp_allstars_get_theme', action: 'wp_allstars_get_theme',
_ajax_nonce: wpAllstars.nonce _wpnonce: wpAllstars.nonce
}, },
success: function(response) { success: function(response) {
if (response.success) { if (response.success) {

View File

@ -660,7 +660,7 @@ function wp_allstars_settings_page() {
<div class="wp-allstars-toggle"> <div class="wp-allstars-toggle">
<div class="wp-allstars-toggle-header"> <div class="wp-allstars-toggle-header">
<div class="wp-allstars-toggle-main"> <div class="wp-allstars-toggle-main">
<label for="wp_allstars_auto_upload_images"> <div class="wp-allstars-toggle-left">
<div class="wp-toggle-switch"> <div class="wp-toggle-switch">
<input type="checkbox" <input type="checkbox"
id="wp_allstars_auto_upload_images" id="wp_allstars_auto_upload_images"
@ -670,11 +670,10 @@ function wp_allstars_settings_page() {
/> />
<span class="wp-toggle-slider"></span> <span class="wp-toggle-slider"></span>
</div> </div>
<?php esc_html_e('Enable Auto Upload Images', 'wp-allstars'); ?> <label for="wp_allstars_auto_upload_images">
</label> <?php esc_html_e('Enable Auto Upload Images', 'wp-allstars'); ?>
<button type="button" class="wp-allstars-expand-settings" aria-expanded="false"> </label>
<span class="dashicons dashicons-arrow-down-alt2"></span> </div>
</button>
</div> </div>
<p class="description"> <p class="description">
<?php esc_html_e('Import images that have external URLs into your Media Library when saving. Consider disabling during large data imports with many external image URLs.', 'wp-allstars'); ?> <?php esc_html_e('Import images that have external URLs into your Media Library when saving. Consider disabling during large data imports with many external image URLs.', 'wp-allstars'); ?>