From 2773c49bb039c52e69c6235280431afae18e49c1 Mon Sep 17 00:00:00 2001
From: Marcus Quinn <marcus@agentdesign.co.uk>
Date: Sun, 16 Mar 2025 04:08:10 +0000
Subject: [PATCH] Fix notification position, set default values, and fix AJAX
 nonce issues

---
 admin/css/wp-allstars-admin.css |  2 +-
 admin/js/wp-allstars-admin.js   | 10 ++++-----
 admin/settings.php              | 37 +++++++++++++++------------------
 3 files changed, 23 insertions(+), 26 deletions(-)

diff --git a/admin/css/wp-allstars-admin.css b/admin/css/wp-allstars-admin.css
index e1064ec..f85b2ca 100644
--- a/admin/css/wp-allstars-admin.css
+++ b/admin/css/wp-allstars-admin.css
@@ -655,7 +655,7 @@ input:checked + .wp-toggle-slider:before {
 .wp-allstars-setting-row label .wp-setting-notification {
     position: absolute;
     right: -60px;
-    top: 0;
+    top: -2px;
     transform: translateY(0);
     line-height: 1.4;
 }
diff --git a/admin/js/wp-allstars-admin.js b/admin/js/wp-allstars-admin.js
index 8150596..def69a8 100644
--- a/admin/js/wp-allstars-admin.js
+++ b/admin/js/wp-allstars-admin.js
@@ -161,11 +161,11 @@ jQuery(document).ready(function($) {
         
         $.ajax({
             url: ajaxurl,
-            type: 'POST',
+            type: 'GET',
             data: {
                 action: 'wp_allstars_get_plugins',
                 category: category || 'minimal',
-                security: wpAllstars.nonce
+                _ajax_nonce: wpAllstars.nonce
             },
             success: function(response) {
                 if (response.success) {
@@ -196,10 +196,10 @@ jQuery(document).ready(function($) {
         
         $.ajax({
             url: ajaxurl,
-            type: 'POST',
+            type: 'GET',
             data: {
                 action: 'wp_allstars_get_theme',
-                security: wpAllstars.nonce
+                _ajax_nonce: wpAllstars.nonce
             },
             success: function(response) {
                 if (response.success) {
@@ -264,7 +264,7 @@ jQuery(document).ready(function($) {
                 data: {
                     action: 'wp_allstars_activate_theme',
                     theme: slug,
-                    security: wpAllstars.nonce
+                    _ajax_nonce: wpAllstars.nonce
                 },
                 success: function(response) {
                     if (response.success) {
diff --git a/admin/settings.php b/admin/settings.php
index d4826d5..1ba007e 100644
--- a/admin/settings.php
+++ b/admin/settings.php
@@ -672,8 +672,8 @@ function wp_allstars_settings_page() {
                                         </div>
                                         <label for="wp_allstars_auto_upload_images">
                                             <?php esc_html_e('Enable Auto Upload Images', 'wp-allstars'); ?>
-                                        </label>
-                                    </div>
+                    </label>
+                </div>
                                 </div>
                                 <p class="wp-setting-description">
                                     <?php esc_html_e('Import images that have external URLs into your Media Library when saving. Consider disabling during large data imports with many external image URLs.', 'wp-allstars'); ?>
@@ -681,25 +681,22 @@ function wp_allstars_settings_page() {
                             </div>
                             <div class="wp-allstars-toggle-settings">
                                 <div class="wp-allstars-setting-row">
-                                    <label for="wp_max_width"><?php esc_html_e('Max Width', 'wp-allstars'); ?></label>
+                                    <label for="wp_allstars_max_width"><?php esc_html_e('Max Width', 'wp-allstars'); ?></label>
                                     <input type="number" 
-                                           id="wp_max_width"
-                                           name="wp_max_width"
-                                           value="<?php echo esc_attr(get_option('wp_allstars_max_width', 1920)); ?>"
-                                           min="0"
+                                           id="wp_allstars_max_width"
+                                           name="wp_allstars_max_width" 
+                                           value="<?php echo esc_attr(get_option('wp_allstars_max_width', 2560)); ?>" 
                                     />
-                                    <p class="description"><?php esc_html_e('Maximum width of uploaded images (px). Leave empty for no limit.', 'wp-allstars'); ?></p>
+                                    <p class="description"><?php esc_html_e('Maximum width for uploaded images in pixels.', 'wp-allstars'); ?></p>
                                 </div>
-
                                 <div class="wp-allstars-setting-row">
-                                    <label for="wp_max_height"><?php esc_html_e('Max Height', 'wp-allstars'); ?></label>
+                                    <label for="wp_allstars_max_height"><?php esc_html_e('Max Height', 'wp-allstars'); ?></label>
                                     <input type="number" 
-                                           id="wp_max_height"
-                                           name="wp_max_height"
-                                           value="<?php echo esc_attr(get_option('wp_allstars_max_height', 1080)); ?>"
-                                           min="0"
+                                           id="wp_allstars_max_height"
+                                           name="wp_allstars_max_height" 
+                                           value="<?php echo esc_attr(get_option('wp_allstars_max_height', 2560)); ?>" 
                                     />
-                                    <p class="description"><?php esc_html_e('Maximum height of uploaded images (px). Leave empty for no limit.', 'wp-allstars'); ?></p>
+                                    <p class="description"><?php esc_html_e('Maximum height for uploaded images in pixels.', 'wp-allstars'); ?></p>
                                 </div>
 
                                 <div class="wp-allstars-setting-row">
@@ -973,8 +970,8 @@ function wp_allstars_settings_page() {
                                             </div>
                                             <label for="wp_allstars_simple_setting" class="wp-setting-label">
                                                 <?php esc_html_e('Example: Simple Toggle', 'wp-allstars'); ?>
-                                            </label>
-                                        </div>
+                    </label>
+                </div>
                                     </div>
                                     <p class="wp-setting-description">
                                         <?php esc_html_e('This is an example of a simple toggle setting without an expandable panel. Currently for demonstration purposes only.', 'wp-allstars'); ?>
@@ -1002,7 +999,7 @@ function wp_allstars_settings_page() {
                                             </div>
                                             <label for="wp_allstars_auto_upload_images">
                                                 <?php esc_html_e('Example: Expandable Panel', 'wp-allstars'); ?>
-                                            </label>
+                    </label>
                                         </div>
                                     </div>
                                     <p class="wp-setting-description">
@@ -1022,8 +1019,8 @@ function wp_allstars_settings_page() {
                                 </div>
                             </div>
                         </div>
-                    </div>
-                <?php endif; ?>
+                </div>
+            <?php endif; ?>
             </div>
         </div>
     </div>